You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there! Thanks again so much for the PR—this is a really helpful addition!
I’m excited to get this merged. Adding more tests to these functions is a win; It will help us catch any tricky side effects down the road and keep the codebase stable. More tests on some functions will improve unwanted side effects in future!
The variable dirs is used in this function. dirs is used as a control mechanism for traversal. That’s how the function now avoids unwanted directories efficiently. The use of os.walk() combined with the slice assignment dirs[:] is a way to controls which subdirectories the loop will enter next. EXCLUDE_DIRS is only used in this function. Maybe in future configurable for users without touching code in a visual UI.
Great work, and thanks again for your contribution!
Updated file header: (C) 2026 @jurgenwigg
I do not want credit for your work!
Regards!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed strange behaviour in the
collect_python_source_files()function:dirsare completely unused. Is that expected?EXCLUDE_DIRScould be a global constant for this module.