meeting-2026-07-02#4391
Merged
Merged
Conversation
Contributor
Author
|
/cc @nodejs/build |
sxa
requested changes
Jul 3, 2026
sxa
left a comment
sxa
left a comment
Member
There was a problem hiding this comment.
Changes have been made in the original hackmd, so I'll leave it to you whether to copy that again and upload it to this PR or accept the suggestions in the github UI
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Contributor
Author
|
No problem, I've committed the suggestions here directly, thank you. |
Contributor
Author
|
Are there any other changes needed? |
sxa
approved these changes
Jul 9, 2026
sxa
left a comment
sxa
left a comment
Member
There was a problem hiding this comment.
Are there any other changes needed?
Not from my perspective.
richardlau
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4382.