fs: add throwIfNoEntry option to fs.lstat/fs.promises.lstat

[Renegade334]

This is present on lstatSync but wasn't added to the other lstat functions in #61178, leaving the API asymmetrical.

Copies a couple of deduplications/simplifications back to the equivalent stat functions.

Refs: #61178

[aduh95]

Having an opt-out of synchronous throw makes perfect sense to allow a more performant path, but I don't think it applies for async API – I get the point of align the APIs, but if there are no use-cases for it, it's probably not worth adding

[Renegade334]

Having an opt-out of synchronous throw makes perfect sense to allow a more performant path, but I don't think it applies for async API – I get the point of align the APIs, but if there are no use-cases for it, it's probably not worth adding

I agreed at the time, but now that it's in (ie. fs.stat/fs.promises.stat), it shouldn't be asymetrically half-in.

[aduh95]

There's precedence for this in #61178

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (b2f6aa3) to head (10413d6).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63116      +/-   ##
==========================================
+ Coverage   89.65%   89.69%   +0.04%     
==========================================
  Files         712      712              
  Lines      220512   221271     +759     
  Branches    42289    42390     +101     
==========================================
+ Hits       197690   198477     +787     
+ Misses      14663    14650      -13     
+ Partials     8159     8144      -15     

Files with missing lines	Coverage Δ
lib/fs.js	98.20% <100.00%> (+<0.01%)	⬆️
lib/internal/fs/promises.js	92.93% <100.00%> (-0.02%)	⬇️
src/node_file.cc	74.20% <100.00%> (-0.03%)	⬇️

... and 81 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SollyBunny]

Having an opt-out of synchronous throw makes perfect sense to allow a more performant path, but I don't think it applies for async API – I get the point of align the APIs, but if there are no use-cases for it, it's probably not worth adding

Its a lot cleaner to do

await fs.lstat(myfile, { throwIfNoEntry: false }

than

/**
 * @type ReturnType<fs.*stat> | undefined
 */
let out = undefined;
try {
    out = await fs.lstat(myfile)
} catch (e) {
    if (e.code !== "ENOENT") throw e
}

1. You need to add types for lsp to go aha yeah it's a fs.Stat!
2. It's bigger and uglier
3. Magic "ENOENT" (might be a nicer way to do that)

I have a project where I use both lstat and stat, I wrap lstat and have it look something like this

The sheer usefulness I feel is enough to validate this.