Skip to content

test: make blob desiredSize assertion robust #64106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 2, 2026
+4 −2
Merged

test: make blob desiredSize assertion robust #64106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/parallel/test-blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,10 @@ assert.throws(() => new Blob({}), {
assert(!done);
setTimeout(common.mustCall(() => {
// The blob stream is now a byte stream hence after the first read,
// it should pull in the next 'hello' which is 5 bytes hence -5.
assert.strictEqual(stream[kState].controller.desiredSize, 0);
// it may have pulled in the next 'hello' which is 5 bytes hence -5.
// The ordering of this timer and the stream's setImmediate() pull
// continuation can vary across platforms.
assert([0, -5].includes(stream[kState].controller.desiredSize));
Comment on lines +357 to +360

@aduh95 aduh95 Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the expected value used to be -5 (hence the comment) until 062ae6f#diff-a81904a70efeb82b159c0e582a8dd5fed7b683367407a220e78924d345488155

}), 0);
})().then(common.mustCall());

Expand Down
Loading