Skip to content

doc: add sxa GPG key (ed25519)#64193

Open
sxa wants to merge 2 commits into
nodejs:mainfrom
sxa:sxa_gpg
Open

doc: add sxa GPG key (ed25519)#64193
sxa wants to merge 2 commits into
nodejs:mainfrom
sxa:sxa_gpg

Conversation

@sxa

@sxa sxa commented Jun 29, 2026

Copy link
Copy Markdown
Member

Part of nodejs/Release#733

Cc @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 29, 2026

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message doesn't meet our guidelines (you need to commit with both -S and -s). You'd need to also add an entry in the bash snippet below

node/README.md

Lines 797 to 806 in 242f2e7

```bash
gpg --keyserver hkps://keys.openpgp.org --recv-keys 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 # Antoine du Hamel
gpg --keyserver hkps://keys.openpgp.org --recv-keys DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 # Juan José Arboleda
gpg --keyserver hkps://keys.openpgp.org --recv-keys CC68F5A3106FF448322E48ED27F5E38D5B0A215F # Marco Ippolito
gpg --keyserver hkps://keys.openpgp.org --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 # Michaël Zasso
gpg --keyserver hkps://keys.openpgp.org --recv-keys 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 # Rafael Gonzaga
gpg --keyserver hkps://keys.openpgp.org --recv-keys C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C # Richard Lau
gpg --keyserver hkps://keys.openpgp.org --recv-keys 108F52B48DB57BB0CC439B2997B01419BD92F80A # Ruy Adorno
gpg --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0 # Ulises Gascón
```

Signed-off-by: Stewart X Addison <sxa@ibm.com>
Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa sxa requested a review from aduh95 June 29, 2026 16:59
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 29, 2026
@aduh95

aduh95 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

If you can land it manually so the commit on main is signed with that key, it's a nice-to-have – but it's also fine if it's unsigned or signed by GH

@sxa

sxa commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

If you can land it manually

Manually = with git node land -S yeah?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants