stream: prefer sync iterator in fromSync#64294
Open
trivikr wants to merge 1 commit into
Open
Conversation
When an input provides both Symbol.iterator and Symbol.asyncIterator, fromSync() should consume the synchronous iterator instead of rejecting the input as async. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Jul 5, 2026
| input, | ||
| ); | ||
| } | ||
| if (typeof input === 'object' && input !== null && typeof input.then === 'function') { |
Contributor
There was a problem hiding this comment.
Shouldn't we also skip this check if input is sync iterable?
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64292
stream/iter'sfromSync()rejected any input that exposedSymbol.asyncIterator, even when the same input also exposedSymbol.iterator.This updates
fromSync()to reject only async-only iterables, allowing dualsync/async iterables to be consumed through their synchronous iterator. A
regression test covers the dual-iterator case.
Assisted-by: openai:gpt-5.5