Skip to content

quic: handle stream writer reset error#64305

Open
yashshinde8585 wants to merge 1 commit into
nodejs:mainfrom
yashshinde8585:fix-quic-stream-writer-error
Open

quic: handle stream writer reset error#64305
yashshinde8585 wants to merge 1 commit into
nodejs:mainfrom
yashshinde8585:fix-quic-stream-writer-error

Conversation

@yashshinde8585

Copy link
Copy Markdown

Summary

This PR addresses an unhandled promise rejection that can occur when a QuicStream writer is reset by the remote peer.

Changes

  • Mark the internal drain promise as handled before rejecting it.
  • Forward the stream error through the appropriate error callback.
  • Add a regression test covering the reported scenario.

Testing

  • Added a regression test:
    • test/parallel/test-quic-stream-writer-unhandled-error.mjs

Fixes: #64290

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 5, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell

jasnell commented Jul 6, 2026

Copy link
Copy Markdown
Member

there appears to be a lint issue in this...

---
data:
  column: 11
  line: 38
  ruleId: no-restricted-syntax
message: '`assert.rejects()` must be invoked with at least two arguments.'
messages:
- data:
    column: 7
    line: 50
    ruleId: no-restricted-syntax
  message: '`assert.rejects()` must be invoked with at least two arguments.'
  severity: error
severity: error
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quic: QuicStream writer creates unhandled error

4 participants