Conversation
|
Review requested:
|
|
I haven't yet looked into the details but a question: I assume that resume-ci will fail if new commits have been added since the last run? |
yes. |
| --repo "$GITHUB_REPOSITORY" \ | ||
| --label 'resume-ci' \ | ||
| --json 'number' \ | ||
| --search 'review:approved' \ |
There was a problem hiding this comment.
I haven't yet looked into the details but a question: I assume that resume-ci will fail if new commits have been added since the last run?
No it won't be picked up until it's approved
There was a problem hiding this comment.
Well, if an approval for the latest commit is there and [resume-ci] is still present then it will fail to start and report such.
f1416fc to
7431638
Compare
Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
7431638 to
83f1b48
Compare
|
@jasnell @mcollina thank you for the reviews, nodejs/node-core-utils#1187 needs those ✅s too before being able to proceed here. |
Adds
[resume-ci]label handling alongside[request-ci]. The scheduled workflow selects up to five approved PRs with either label in one query. A shared script checks each PR's current labels and choosesncu-ci runorncu-ci resume, skipping PRs with neither label.Failed resume attempts receive
[resume-ci-failed]and a comment with a diagnostic summary, full output, and workflow link.If both request labels are present, the script removes them, adds
[request-ci-failed]and[resume-ci-failed], and reports the conflict once without starting or resuming CI.Before merging:
ncu-ci resume.@node-core/utilsrelease containing that change.[resume-ci]label in nodejs/node.[resume-ci-failed]label in nodejs/node.