Adds link to beta docs#8998
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Introduces an optional Reviewed by Cursor Bugbot for commit 9ce9781. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8998 +/- ##
==========================================
+ Coverage 75.39% 75.43% +0.04%
==========================================
Files 98 98
Lines 8636 8642 +6
Branches 318 318
==========================================
+ Hits 6511 6519 +8
+ Misses 2121 2119 -2
Partials 4 4 ☔ View full report in Codecov by Harness. |
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
if we dont like the accent approach and how much it drills through the schema and makes file changes - we could try to key the styling entirely off of the URL value - which would be less intrusive long-term, but sorta brittle
There was a problem hiding this comment.
Pull request overview
Adds a new “Beta Docs” entry to the site’s top navigation and introduces an “accent” styling option so the beta docs link can be visually highlighted alongside existing nav items.
Changes:
- Add a new
betaDocsnavigation entry (label + URL +_blanktarget) and wire it through the site navigation mapping/types. - Add an
accentboolean prop toNavItem/NavBarand implement the corresponding CSS module styling. - Update Storybook to showcase the new “Beta Docs” nav item.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/Containers/NavBar/NavItem/index.tsx | Adds accent prop support when rendering nav links. |
| packages/ui-components/src/Containers/NavBar/NavItem/index.module.css | Introduces the .accent visual style for highlighted nav items. |
| packages/ui-components/src/Containers/NavBar/index.tsx | Threads accent through NavBar → NavItem rendering. |
| packages/ui-components/src/Containers/NavBar/index.stories.tsx | Demonstrates the new “Beta Docs” item and accent styling in Storybook. |
| packages/i18n/src/locales/en.json | Adds the betaDocs navbar link label for English. |
| apps/site/types/navigation.ts | Extends navigation types to include betaDocs and optional accent. |
| apps/site/navigation.json | Adds the betaDocs top navigation entry (external link, _blank, accented). |
| apps/site/hooks/useSiteNavigation.ts | Maps the new accent field through the navigation hook. |
| apps/site/components/withNavBar.tsx | Passes accent through when constructing NavBar items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
both AI bots are too ill-informed to know how we translate based on en.json only - i'd be game to turn off cursor entirely |
|
lol those functional tests are really banking on this being up to date in crowdin. brittle |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c1a02eb. Configure here.
|
okay 2l point:
So in overall I think most user will not get what happened |
| dark:bg-brand-600/15 | ||
| dark:ring-brand-400/20 | ||
| ring-1 | ||
| ring-inset; |
There was a problem hiding this comment.
we should add small transition because now on hover it's pass from something transparent to solid instantly
|
I'm not sure how i feel about this. The beta docs aren't 1:1 with the new docs, and only serve as a visual preview of the latest |
araujogui
left a comment
There was a problem hiding this comment.
maybe should we start with a announcement banner only first?
At the very least, it should be updated to the latest version, which is Node.js 26, right? The preview is still on Node.js 24.
I think that's the best approach for now |
The preview is purely visual (at the moment), and isn't populated with the correct data, for example, it's generated with the doc files of the main branch of At the very least, the beta docs should be updated to generate with the latest tag on the That being said, none of this is an 'issue' with doc-kit, it's just that our preview was set up in a way to showcase the visuals, and not in a way to make them accurate to readers. |
|
all good points - i am trying to nudge us toward more exposure here. it helps us get more feedback from those not following along. i think its the right pathway, after 2+years
I'd disagree - the design is the user experience |


Description
Good feedback within nodejs/node#62045 has mentioned that despite social media posts and github issues, most users may have not yet seen the beta docs. To expand an ever-increasing feedback gathering campaign, I think we should publicize the beta docs on par with the official docs.
Unsure if this has been proposed before - apologies if I missed it.
Large Light/Dark


Mobile

Validation
Related Issues
nodejs/node#62045
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.