fix: navbar active link should match the most specific path

[ryzrr]

Description

fix navbar active-link matching that only compared the first path segment, so two items sharing a segment could highlight together. now the most specific link (longest matching prefix) wins.

Validation

run pnpm test in packages/ui-components for the new getActiveNavLink and active-override tests. node's own top nav is unchanged since its items are single-segment, this fixes the nested case for package consumers whose nav has items like /about and /about/sponsors.

Related Issues

none, raised with the maintainers beforehand.

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run pnpm format to ensure the code follows the style guide.
• I have run pnpm test to check if all tests are passing.
• I have run pnpm build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
nodejs-org	Ready	Preview	Jul 5, 2026 6:42pm

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[cursor]

PR Summary

Low Risk
Scoped UI navigation highlighting in ui-components with unit tests; default BaseActiveLink behavior is unchanged when active is omitted.

Overview
Fixes navbar active-state when multiple items share a path prefix (e.g. /about and /about/sponsors), where both could highlight under the old first-segment / per-item allowSubPath behavior.

Adds exported getActiveNavLink, which chooses the longest internal link that equals the pathname or is a prefix (pathname === link or pathname.startsWith(link + '/')), ignoring externals and false positives like /about-us. NavBar computes one winner and passes active={link === activeLink} into each NavItem.

BaseActiveLink gains an optional active boolean: when set, it overrides pathname/allowSubPath matching so the bar can drive highlighting centrally; when omitted, behavior stays as before.

^{Reviewed by Cursor Bugbot for commit 0079837. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.54%. Comparing base (a5b11b7) to head (0079837).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ages/ui-components/src/Containers/NavBar/index.tsx	80.00%	3 Missing ⚠️
.../ui-components/src/Common/BaseActiveLink/index.tsx	77.77%	2 Missing ⚠️
...components/src/Containers/NavBar/NavItem/index.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8999      +/-   ##
==========================================
- Coverage   75.39%   74.54%   -0.85%     
==========================================
  Files          98      100       +2     
  Lines        8636     8801     +165     
  Branches      318      325       +7     
==========================================
+ Hits         6511     6561      +50     
- Misses       2121     2236     +115     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[AugustinMauroy]

LGTM!