fix: add missing spaces and tabs to HTTP tspecials validation#5425
Closed
shivarm wants to merge 1 commit into
Closed
fix: add missing spaces and tabs to HTTP tspecials validation#5425shivarm wants to merge 1 commit into
shivarm wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5425 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 110 110
Lines 36993 36995 +2
=======================================
+ Hits 34535 34537 +2
Misses 2458 2458 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Please rebase and add a test |
KhafraDev
requested changes
Jun 14, 2026
KhafraDev
left a comment
KhafraDev
left a comment
Member
There was a problem hiding this comment.
The comments above isTSpecial and isToken do not match the implementation.
token := 1*<any (US-ASCII) CHAR except SPACE, CTLs,
or tspecials>
tspecials := "(" / ")" / "<" / ">" / "@" /
"," / ";" / ":" / "\" / <">
"/" / "[" / "]" / "?" / "="
; Must be in quoted-string,
; to use within parameter values
> Correct the isTSpecial function to fully comply with the RFC 2616 > specification by including space (0x20) and horizontal tab (0x09). > Also include test and fixed an incorrect comment tracking the '=' character Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Member
|
I meant that tspecial and token is defined in RFC 2045 https://datatracker.ietf.org/doc/html/rfc2045 |
Member
|
RFC 2616 makes no mention of tspecials and is obsolete. Please don't use an ai to think for you, verify whatever it comes up with next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the isTSpecial function to fully comply with the RFC 2616 specification by including space
(0x20)and horizontal tab(0x09). Also fixed an incorrect comment tracking the=character.