feat: add some storybook entries - #3141
Open
leekeh wants to merge 6 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesStorybook now includes component stories, mock fixtures, decorators, controls, responsive examples, loading states, and autodocs metadata. The preview decorator applies the selected global theme class to the document root. Storybook component coverage
Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Question for reviewer: do we need to have code coverage for stories? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.storybook/preview.ts:
- Around line 76-78: Update the theme application logic around themeClass so it
assigns the derived light/dark value to document.documentElement.dataset.theme,
matching the selectors in main.css. Remove the light/dark class removal and
addition unless another Storybook stylesheet explicitly requires those classes.
In `@app/components/PaginationControls.stories.ts`:
- Around line 16-33: Synchronize the local refs in the PaginationControls
story’s render setup with Storybook args after initialization. Add watchers for
args.mode, args.pageSize, and args.currentPage that update the corresponding
mode, pageSize, and currentPage refs when control-panel values change, while
preserving the existing v-model bindings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fc7b6132-12f5-4301-8e0d-8b7b782bc038
📒 Files selected for processing (23)
.storybook/preview.tsapp/components/About/GovernanceList.stories.tsapp/components/About/LogoImg.stories.tsapp/components/About/LogoList.stories.tsapp/components/Alert.stories.tsapp/components/BaseCard.stories.tsapp/components/Brand/Customize.stories.tsapp/components/Code/DirectoryListing.stories.tsapp/components/Code/FileTree.stories.tsapp/components/Code/Header.stories.tsapp/components/Code/MobileTreeDrawer.stories.tsapp/components/Code/SkeletonLoader.stories.tsapp/components/Code/Viewer.stories.tsapp/components/CollapsibleSection.stories.tsapp/components/CopyToClipboardButton.stories.tsapp/components/Input/Base.stories.tsapp/components/Link/Link.stories.tsapp/components/LoadingSpinner.stories.tsapp/components/PaginationControls.stories.tsapp/components/ProgressBar.stories.tsapp/components/ProvenanceBadge.stories.tsapp/components/SkeletonBlock.stories.tsapp/components/SkeletonInline.stories.ts
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fixes some of #1841
🧭 Context
If desired, I can scaffold the stories for the remaining components, but I'd like to know if this is the direction you want to take.
I also think that it could be nice to organize the components a bit more, to store some core UI components separate from specific features. This will also help with storybook organization, as it should mirror the repo structure.
📚 Description