This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Upstream nvim at 23fe6dba1 breaks tab completion #399
Description
My testing minimal init.vim
The part of the mapping that is relevant:
require('astronauta.keymap')
vim.keymap.inoremap{'<Tab>', require("completion").smart_tab, buffer=true, silent=true}
vim.keymap.inoremap{'<S-Tab>', require("completion").smart_s_tab, buffer=true, silent=true}How to reproduce
Compile the upstream at this commit. Use tab completion.
Expected behaviour
Completion popup to show up, but it doesn't.
I can confirm that completion works at this commit.
Reacted by Sergey Kacheev, Anton Smirnov, Kai Howelmeyer, Marcos Simental, Jan Steinke, Ibraheem Ahmed, b3nj5m1n, Pratchaya and Craig Furman
Activity
stormc commentedon Sep 8, 2021
The handler function's signature in
source/lsp.luaneeds to be updated, possibly adding a backwards-compatible wrapper for neovim versions prior to this commit. As an intermediate hack, this should help:mrkz commentedon Sep 29, 2021
@stormc thanks for the workaround, looking forward to the fix 😄
stormc commentedon Sep 30, 2021
@mrkz You're welcome, #400 does also proper-fix hover and signature for which you would have to apply this workaround's gist as well, so I suggest to use that instead of this workaround until it's been merged.