Skip to content

test(#108): cover nested @ with phi-is-not-first - #1245

Merged
yegor256 merged 1 commit into
objectionary:masterfrom
VasilevNStas:fix/issue-108-phi-nested-at
Sep 1, 2026
Merged

yegor256 merged 1 commit into
objectionary:masterfrom
VasilevNStas:fix/issue-108-phi-nested-at

Conversation

@VasilevNStas

Copy link
Copy Markdown
Contributor

fix #108

What

A regression test for the exact case from the issue: a nested @
attribute (bar > @ inside a child object) is covered by the existing
names/phi-is-not-first lint.

Why

The parser lifts a nested @ up to the top level of its parent, where it
becomes a φ sibling that is never first (the container always precedes
it). The phi-is-not-first lint checks exactly that, so the confusing
code from the issue is already reported. The claim was made in
#108 (comment),
but was not backed by a test. This pack locks the behavior in, so a future
regression in the lint or in the parser would be caught by CI.

Changes

  • src/test/resources/org/eolang/lints/packs/single/phi-is-not-first/catches-nested-at.yaml — the new regression pack

Both mvn test (591 tests) and mvn clean install -Pqulice pass.

@VasilevNStas

Copy link
Copy Markdown
Contributor Author

@volodya-lombrozo plz review

@yegor256
yegor256 merged commit 2c34ff4 into objectionary:master Sep 1, 2026
22 checks passed

yegor256 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution!


Generated by Claude Code

@VasilevNStas
VasilevNStas deleted the fix/issue-108-phi-nested-at branch September 5, 2026 10:09
@0crat

0crat commented Sep 5, 2026

Copy link
Copy Markdown

@VasilevNStas Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (12) hits-of-code. Please, keep them coming. Your running score is +542; don't forget to check your Zerocracy account too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@ attribute is not at the highest level

3 participants