feraz - Technical Training - #1386
Conversation
|
|
qucol-odoo
left a comment
qucol-odoo
left a comment
There was a problem hiding this comment.
Thank you for your great work 👌 I wrote a few comments which are mostly nitpicks, try to apply them whenever you find the time :)
I see that your latest commit titles are correctly formatted, that's nice 👍 You could try to rename the previous ones to please the runbot 😇
972335b to
f193788
Compare
qucol-odoo
left a comment
qucol-odoo
left a comment
There was a problem hiding this comment.
Good job! I highlighted a few nitpicks :)
qucol-odoo
left a comment
qucol-odoo
left a comment
There was a problem hiding this comment.
Few last comments on this PR, it's some very good job 👏 Feel free to apply them or simply read them.
In a real case scenario, it wouldn't make much sense to have commits fixing issues from other commits belonging to the same PR, because it means that you are introducing an issue and fixing it simultaneously: it would be better to simply not introduce it at all. It would be a great exercise for you to try to get rid of all the [FIX] commits in your PR (hint: you should probably use git rebase -i). Ultimately you could also squash commits to have one per chapter, or even squash everything as one big [ADD] commit, it's kinda up to you, as long as you experiment a bit with the interactive rebasing (mostly the edit and squash options) :)
9bfce93 to
fa0e09b
Compare
[FIX] estate: estate_property to estate.property
2b47cbc to
c649dc6
Compare
3 participants
No description provided.