yalla - Technical Training - #1387
Conversation
|
|
1e36dd6 to
e48b2d2
Compare
e48b2d2 to
639ece2
Compare
Extracted all view into their respective view xmls. Fixed some bugs and linting.
639ece2 to
9ac374b
Compare
yoba-odoo
left a comment
yoba-odoo
left a comment
There was a problem hiding this comment.
Good work 💯
Some comments for enhancements, could you also please try to make the ci/* checks pass
| existing_prices = estate_property.offer_ids.mapped("price") | ||
|
|
||
| if existing_prices: | ||
| min_price = min(existing_prices) |
There was a problem hiding this comment.
Since you defined an _order for the offers model with price so any recordset of offers will be sorted according to the price so to get the minimum you can do something like estate_property.offer_ids[-1]
There was a problem hiding this comment.
Yeah, that makes sense. But for the sake of readability, wouldn't it be better to leave it as is so the reader doesn't have to guess why I grabbed the last item? specially since its a low cost operation either way
| "security/ir.model.access.csv", | ||
| "views/estate_property_views.xml", | ||
| "views/estate_property_actions.xml", | ||
| "views/estate_menus.xml", |
There was a problem hiding this comment.
Am I missing something? why didn't you introduced the other xml files here?
estate_property_offer_views, estate_property_type_views and res_users_views
I would be surprised if they are working without adding them to the manifest file😂
There was a problem hiding this comment.
i forgot to add them but for some reason the local server didn't break so i thought everything is fine 😂😂
|
Another thing I just noticed for the commits we normally name them like this |
Yeah i have read the git guidelines, i thought this is how you would want it, to know exactly which chapter is each commit. so in this case, the Chapter is the name of the module |
672e778 to
27e3fc2
Compare
3 participants
No description provided.