Onboarding Juica Server 101 by JuanICasareski · Pull Request #1391 · odoo/tutorials

JuanICasareski · 2026-08-18T08:14:38Z

No description provided.

robodoo · 2026-08-18T08:14:41Z

yoba-odoo

Good work 💪
Just a few comments, and always add a newline by the end of the file

yoba-odoo · 2026-08-18T11:38:04Z

+from . import estate_property
+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer


We should always have a newline by the end of each file

Damn I should've set up the linter haha

yoba-odoo · 2026-08-18T11:39:41Z

+        copy=False,
+        default=fields.Date.today() + relativedelta(months=3)
+    )
+


Not the best practice to have a newline in between the fields' definition, readability wise

yoba-odoo · 2026-08-18T13:08:33Z

@@ -0,0 +1,76 @@
+from odoo import fields, models
+from dateutil.relativedelta import relativedelta
+


We normally should always have two blank lines before the definition of the class

yoba-odoo · 2026-08-18T13:11:57Z

@@ -0,0 +1,8 @@
+from odoo import fields, models
+
+class EstatePropertyType(models.Model):


heads up for the typo here. This is EstatePropertyTag not Type 😅

haha I shouldn't be copying file so freely, fixed

yoba-odoo · 2026-08-18T13:31:57Z

+        self.garden_area = 10 if self.garden else 0
+        # Nasty magic string. I should turn the option into a variable and then reference it
+        self.garden_orientation = "north" if self.garden else None


Suggested change

self.garden_area = 10 if self.garden else 0

# Nasty magic string. I should turn the option into a variable and then reference it

self.garden_orientation = "north" if self.garden else None

if self.garden:

self.garden_area = 10

# Nasty magic string. I should turn the option into a variable and then reference it

self.garden_orientation = "north"

else:

self.garden_area = 0

self.garden_orientation = None

better to have it like this instead of checking twice, wdyt?

I would normally prefer a return inside the if self.garden and what would've been the else block as a fallback.

Something along the lines of:

if self.garden: self.garden_area = 10 return self.garden_area = 0

idk enough about the company's guidelines or maybe what you usually do, so....

That would be a good approach as well 👌

yoba-odoo

Good work 👏 👏

Just a few comments. Also try to make the ci/* checks to pass, check what are the errors and fix them

yoba-odoo · 2026-08-20T11:52:57Z

@@ -0,0 +1 @@
+from . import estate_property


newline at the end of file 😅

… buttons

…fers form view

…rty view

…ions on list views

…perty deletion when pending

yoba-odoo reviewed Aug 18, 2026

View reviewed changes

yoba-odoo reviewed Aug 20, 2026

View reviewed changes

JuanICasareski force-pushed the 19.0-onboarding-juica branch from ef1b9ae to 7aec590 Compare August 20, 2026 14:14

JuanICasareski added 24 commits August 24, 2026 11:24

[ADD] estate: real estate module

1eb65aa

[ADD] estate: models views & search filters

224b862

[ADD] estate: new state, buyer, & type fields

0058db8

[ADD] estate: tags records, tags on form & list views for estate record

a6351ea

[ADD] estate: property offers, offer vies, & offers tab on property view

cc2a5df

[ADD] estate: computed & onchange fields

5772c87

[ADD] estate: sold & cancel property buttons, & accept & refuse offer…

80c7b7c

… buttons

[LINT] estate: add missing newlines & spacing, & remove extra spacing

2823d1c

[FIX] estate: check property_state by using referenced property on of…

1792990

…fers form view

[ADD] estate: models constraints

4307ea0

[ADD] estate: type inline view, action buttons, & status bar on prope…

0be201a

…rty view

[ADD] estate: offers & properties decoration on list views, & decorat…

d373968

…ions on list views

[ADD] estate: default filter for properties view

777be9b

[ADD] estate: stat button on property types to offers

8e8ed28

[ADD] estate: set state to offer when creating an offer & prevent pro…

e279e91

…perty deletion when pending

[ADD] estate: show associated properties on user view

2a536d6

[FIX] estate: prevent batch creation of offers lower than the best offer

af7a716

[FIX] estate: views order so that runbot runs

b582df1

[ADD] estate: create invoice on property sold

468b0a8

[ADD] estate: kanban view on real state properties

eeee378

[REF] estate: merge offer & received property states into one

8b90efa

[IMP] estate: remove unnecessary check for property state & offer status

1d89de7

[ADD] estate: test offer creation & property selling

fa84104

[ADD] estate: garden check & uncheck test case

0465215

JuanICasareski force-pushed the 19.0-onboarding-juica branch 2 times, most recently from c0a535b to 18d3715 Compare August 24, 2026 09:31

[FIX] estate: float checks on create & sell test cases

ab0b480

JuanICasareski force-pushed the 19.0-onboarding-juica branch from 18d3715 to ab0b480 Compare August 24, 2026 11:25

		@@ -0,0 +1,76 @@
		from odoo import fields, models
		from dateutil.relativedelta import relativedelta

		@@ -0,0 +1,8 @@
		from odoo import fields, models

		class EstatePropertyType(models.Model):

		@@ -0,0 +1 @@
		from . import estate_property No newline at end of file

Uh oh!

Conversation

JuanICasareski commented Aug 18, 2026

Uh oh!

robodoo commented Aug 18, 2026

Uh oh!

yoba-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JuanICasareski Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yoba-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JuanICasareski Aug 18, 2026 •

edited

Loading