fix: harden Vary caching and collapsed forwarding - #65
Draft
sendya wants to merge 2 commits into
Draft
Conversation
…ate Vary data serialization to a robust JSON-based schema
…oup using request header fingerprinting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Varycannot express the distinction.Motivation
Collapsed forwarding regressed after the flight key began fingerprinting the complete request header map. Request-local metadata such as
X-Request-Idx, request IDs, and tracing fields then produced different keys for otherwise equivalent cache misses, causing every concurrent request to reach the origin.Simply returning to an object-only key would make cold misses unsafe for different methods, ranges, authentication contexts, or response representations. Vary identity serialization also needed stronger field-boundary guarantees and compatibility with existing cache entries.
Implementation
Vary.Varyfields before fan-out.Impact
Equivalent concurrent full-cache misses once again collapse to a single origin request, including requests carrying unique correlation metadata. Requests that select different representations or carry response-altering controls remain isolated, preserving response correctness and cache safety.
Validation
go test -count=1 ./server/middleware/caching ./pkg/x/http ./proxyCGO_ENABLED=1 go test -race -count=1 -run '^TestObjectFlight' ./server/middleware/cachinggo vet ./server/middleware/caching ./pkg/x/http ./proxygo test -count=1 -v ./tests/all-features/caching -run '^TestCollapsedForwardingObjectFlight$'against a local Tavern instancegit diff --check