Repository navigation
deps: update shell-quote to 1.12.0 - #622
Conversation
01d5955 to
107194b
Compare
|
👍 |
|
Upgrading the version to 1.11.0 will suffice to fix the reported vulnerability, but I can bump the version to 1.12.0 and include a test if needed. |
|
Hi @Abicodexi, I opened #625 for the same CVE without noticing this PR first, so I'm closing mine in favor of this one. It included a regression test that also applies to 1.11.0, in case it's useful here: efe9536 It covers a passthrough argument containing both There's also #626 tracking the CVE, if you'd like to add |
Hi @Mayvis, I appreciate that. I can include the regression test here if you don't mind? |
|
Not at all, please go ahead! Cherry-picking efe9536 should apply cleanly, since it only touches |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1d64f16 to
1674182
Compare
|
@gustavohenke thanks for merging this. What about releasing a new version of the package? In this way, we can update our dependency as well |
Co-authored-by: Sebastian Seitalahti <sebastian.seitalahti@knowit.fi> Co-authored-by: Mayvis <kevin73911@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Yup, it's published on v10.0.6/v9.2.5! Laptop battery died during merge and I forgot to get back to it 🤦 |
Closes #626
Updates
shell-quotefrom1.9.0to1.12.0and refreshespnpm-lock.yamlto address CVE-2026-102422.The vulnerability allows command injection through
quote()when a comment token is followed by a string containing a line terminator. Version1.11.0fixes this by rejecting line terminators in tokens following a comment.Validation
pnpm test --runlib/command-parser/expand-arguments.spec.tsfor an argument with both ' and !. It passes with 1.12.0 and fails with 1.9.0. Credit to @Mayvis for the test.