Add all default ruff lint rules which have auto fixes available - #5491
Open
DylanRussell wants to merge 8 commits into
Open
Add all default ruff lint rules which have auto fixes available#5491DylanRussell wants to merge 8 commits into
DylanRussell wants to merge 8 commits into
Conversation
emdneto
reviewed
Jul 30, 2026
| "G", # https://docs.astral.sh/ruff/rules/#flake8-logging-format-g | ||
| "TID", # https://docs.astral.sh/ruff/rules/#flake8-tidy-imports-tid | ||
| "UP", # https://docs.astral.sh/ruff/rules/#pyupgrade-up | ||
| "YTT101", "YTT102", "YTT103", "YTT201", "YTT202", "YTT203", "YTT204", "YTT301", |
Member
There was a problem hiding this comment.
do we really need all of those rules?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated select = [...] in pyproject.toml
to include the 407 stable default rules from https://docs.astral.sh/ruff/default-rules/ (excluding 6 preview-only rules to avoid CLI warnings).
Updated ignore = [...] in pyproject.toml to include E501 alongside the 34 unfixable rule codes from the default ruleset.
I can try adding and fixing those in a separate CL.
Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: