Test: Attribute Only Iterations - #1916
Open
ax3l wants to merge 1 commit into
Open
Conversation
Check that we can write and read iterations that only contain attributes. Should work with ADIOS2 BP5, HDF5 and text backends.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| TEST_CASE("attributes_only_over_iterations_test", "[serial]") |
franzpoeschel
requested changes
Aug 4, 2026
| } | ||
| } | ||
|
|
||
| void attributes_only_over_iterations_test( |
Contributor
There was a problem hiding this comment.
Could you please move new test code to separate files under test/Files_SerialIOto not blow upSerialIOTests.cpp` further :)
| * carries the value written for its iteration. | ||
| */ | ||
| { | ||
| Series read(name, Access::READ_ONLY); |
Contributor
There was a problem hiding this comment.
Since the parsing procedures for READ_ONLY and READ_LINEAR are internally very different, it might be worth to run the same read test also for READ_LINEAR:
Series read(name, Access::READ_LINEAR);
read.parseBase();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that we can write and read iterations that only contain attributes. Should work with ADIOS2 BP5, HDF5 and text backends.