fix(logging): redact Azure api-key header in HttpLoggingInterceptor#717
Open
vincerevu wants to merge 1 commit intoopenai:mainfrom
Open
fix(logging): redact Azure api-key header in HttpLoggingInterceptor#717vincerevu wants to merge 1 commit intoopenai:mainfrom
vincerevu wants to merge 1 commit intoopenai:mainfrom
Conversation
When `OPENAI_LOG` is configured, `HttpLoggingInterceptor` logs HTTP requests/responses. Previously, only the `Authorization` header was redacted. This commit also redacts the `api-key` header to ensure Azure API keys are not exposed in application logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents Azure API keys from being exposed in application logs by redacting the
api-keyheader inHttpLoggingInterceptor.What changed
redactHeader("api-key")redactHeader("Authorization")Why
When request logging is enabled, the Azure
api-keyheader may otherwise be written to logs in plaintext. This creates a risk of credential leakage during debugging or in downstream log systems.Impact
Verification
HttpLoggingInterceptorAPI