perf(json): cache JsonMapper instance in jsonMapper()#718
Open
vincerevu wants to merge 2 commits intoopenai:mainfrom
Open
perf(json): cache JsonMapper instance in jsonMapper()#718vincerevu wants to merge 2 commits intoopenai:mainfrom
vincerevu wants to merge 2 commits intoopenai:mainfrom
Conversation
Cache the Jackson JsonMapper instance in a lazy val to avoid the massive performance overhead of registering modules and building the mapper on every single invocation. This single lazily-initialized instance is thread-safe and can be reused globally.
Cache the Jackson JsonMapper instance in a lazy val to avoid the massive performance overhead of registering modules and building the mapper on every single invocation. This single lazily-initialized instance is thread-safe and can be reused globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes
jsonMapper()by returning a single lazily initialized and cachedJsonMapperinstance instead of building a new mapper on every call.What changed
JsonMapper.builder()...build()construction with a cached singleton-style mapperWhy
Building a Jackson mapper is relatively expensive because it registers modules and applies configuration during construction. Since
jsonMapper()can be called frequently across parsing and serialization paths, recreating the mapper on every invocation adds unnecessary CPU and allocation overhead.Impact
jsonMapper()callsNotes
Jackson
ObjectMapper/JsonMapperinstances are thread-safe after configuration, so reusing a single initialized instance is safe here.Verification
jsonMapper()repeatedly