Skip to content

refactor(pkg): components to script setup (modals) - #3040

Open
JammingBen wants to merge 1 commit into
mainfrom
refactor/pkg-components-to-script-setup-#2
Open

refactor(pkg): components to script setup (modals)#3040
JammingBen wants to merge 1 commit into
mainfrom
refactor/pkg-components-to-script-setup-#2

Conversation

@JammingBen

Copy link
Copy Markdown
Member

refs #1462

@JammingBen
JammingBen requested a review from AlexAndBear August 5, 2026 12:09
@JammingBen JammingBen self-assigned this Aug 5, 2026
@JammingBen JammingBen added the Type:Maintenance E.g. technical debt, packaging, etc. label Aug 5, 2026
@JammingBen
JammingBen requested a lite review from Copilot August 5, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR advances the long-running refactor in #1462 by converting several modal components in web-pkg from Options API to Vue 3 <script setup> with typed defineProps/defineEmits, and aligns the corresponding unit tests with the new component instance shape.

Changes:

  • Refactored multiple modal components to <script setup> and migrated props/emits to typed defineProps / defineEmits.
  • Updated modal unit tests to access script-setup bindings/methods on wrapper.vm (using as any where needed).
  • Adjusted iframe URL handling in picker-style modals to use iframeUrl.href directly in templates/tests.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/web-pkg/src/components/Modals/SaveAsModal.vue Converted to <script setup> and kept iframe/message handling + save/open logic.
packages/web-pkg/src/components/Modals/FilePickerModal.vue Converted to <script setup> and updated typed props for callback payload.
packages/web-pkg/src/components/Modals/ResourceConflictModal.vue Converted to <script setup> with destructured prop defaults and retained conflict resolution callbacks.
packages/web-pkg/src/components/Modals/DatePickerModal.vue Converted to <script setup> with typed emits for confirm/cancel.
packages/web-pkg/src/components/Modals/UnsavedChangesModal.vue Converted to <script setup> with typed emits and close handler.
packages/web-pkg/src/components/Modals/SpaceMoveInfoModal.vue Converted to <script setup> with typed defineProps.
packages/web-pkg/tests/unit/components/Modals/SaveAsModal.spec.ts Updated assertions and method invocation to match script-setup instance shape.
packages/web-pkg/tests/unit/components/Modals/FilePickerModal.spec.ts Updated assertions and method invocation to match script-setup instance shape.
packages/web-pkg/tests/unit/components/Modals/ResourceConflictModal.spec.ts Updated computed/method access to match script-setup instance shape.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/web-pkg/src/components/Modals/SaveAsModal.vue Outdated
@JammingBen
JammingBen force-pushed the refactor/pkg-components-to-script-setup-#2 branch from 296b710 to ea43ab7 Compare August 5, 2026 12:15
@JammingBen JammingBen changed the title refactor(pkg): components to script setup refactor(pkg): components to script setup (modals) Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants