feat: move commonly used attributes from XModuleMixin to XBlock#906
Open
irtazaakram wants to merge 2 commits intomasterfrom
Open
feat: move commonly used attributes from XModuleMixin to XBlock#906irtazaakram wants to merge 2 commits intomasterfrom
irtazaakram wants to merge 2 commits intomasterfrom
Conversation
kdmccormick
approved these changes
Apr 17, 2026
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Just one request, good to merge otherwise.
Comment on lines
+981
to
+985
|
|
||
| This method avoids direct attribute access and uses ``getattr`` to safely | ||
| handle cases where attributes like ``display_name`` or ``usage_key`` may | ||
| not be present. | ||
|
|
Member
There was a problem hiding this comment.
usage_key is always present. Anyway, this is an implementation detail, so it is better to leave it out of the docstring.
Suggested change
| This method avoids direct attribute access and uses ``getattr`` to safely | |
| handle cases where attributes like ``display_name`` or ``usage_key`` may | |
| not be present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to openedx/openedx-platform#38271
It moves a set of commonly used attributes out of the legacy
XModuleMixinintoXBlock, since they are not specific toXModulebehavior and are widely relied upon across most XBlocks.The update also includes corresponding tests (generated with assistance from Claude Code), which have been carefully reviewed and refined.