Skip to content

fix: add #page-notification to container_editor.html for XBlock error display#38711

Open
Anas12091101 wants to merge 1 commit into
openedx:masterfrom
mitodl:anas/fix-silent-ora-validation-error-in-editor-modal
Open

fix: add #page-notification to container_editor.html for XBlock error display#38711
Anas12091101 wants to merge 1 commit into
openedx:masterfrom
mitodl:anas/fix-silent-ora-validation-error-in-editor-modal

Conversation

@Anas12091101
Copy link
Copy Markdown
Contributor

Description

The container_editor.html template was missing a #page-notification element.
This template is used when the Course Authoring MFE opens legacy XBlock editors
(like ORA) in a ModalIframe via /xblock/{id}/action/edit. Without this element,
the NotificationView had no DOM target, causing XBlock runtime error notifications
(e.g. "Validation error: dates out of order") to fail silently on save.

Useful information to include:

  • Which edX user roles will this change impact? Course Author
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
image
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

https://github.com/mitodl/hq/issues/11318

Testing instructions

Testing Instructions:

  1. Navigate to a course in Studio (via the Course Authoring MFE) and open a unit containing an ORA (Open Response Assessment) component, or create a new ORA problem

  2. Click the Edit button on the ORA component to open the legacy editor modal.

  3. In the ORA editor, configure step dates out of order — e.g., set a step's start date earlier than the previous step's start date.

  4. Click Save.

  5. Expected (after fix): A red error notification appears at the bottom of the editor modal with a message like "OpenAssessment Save Error: Validation error: This step's start date cannot be earlier than the previous step's start date." The XBlock data is not saved.

  6. Expected (before fix): No error notification is shown. The save fails silently with no feedback to the user.

  7. Verify that saving with valid dates still works correctly — the modal closes and the component refreshes.

Deadline

"None"

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 4, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @Anas12091101!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 4, 2026
@Anas12091101 Anas12091101 moved this from Needs Triage to Ready for Review in Contributions Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants