feat: apply ADRs standardization to enrollment apis#38724
feat: apply ADRs standardization to enrollment apis#38724taimoor-ahmed-1 wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @taimoor-ahmed-1! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
9318985 to
053ba22
Compare
Description
Introduces /api/enrollment/v2/ as a parallel new version of the enrollment API, applying the FC-0118 ADRs from the start. v1 endpoints at /api/enrollment/v1/ are unchanged — clients migrate at their own pace.
What's new
openedx/core/djangoapps/enrollments/v2/ — viewsets, service layer, paginator, forms, serializers, tests
EnrollmentViewSet consolidates v1's EnrollmentListView + UnenrollmentView + EnrollmentAllowedView into a single router-registered ViewSet (actions: list, create, unenroll, allowed)
EnrollmentRetrieveView, UserRolesView, CourseEnrollmentDetailView, EnrollmentsAdminListView for endpoints with URL shapes that don't fit a router
EnrollmentOperationsService centralizes business logic and raises DRF exceptions (modern ADR 0029 pattern)
StandardizedErrorMixin promoted from cms/.../rest_api/mixins.py to openedx/core/lib/api/mixins.py so non-contentstore apps can use it