Skip to content

feat: remove legacy Django unit editor - #38985

Draft
salman2013 wants to merge 1 commit into
masterfrom
salman/remove-legacy-unit-editor
Draft

feat: remove legacy Django unit editor#38985
salman2013 wants to merge 1 commit into
masterfrom
salman/remove-legacy-unit-editor

Conversation

@salman2013

@salman2013 salman2013 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the LEGACY_STUDIO_UNIT_EDITOR waffle flag and all code paths behind it — the MFE-based unit editor (frontend-app-authoring) is now always active
  • Deletes container.html (legacy full-page unit editor) and container_editor.html (legacy xblock edit modal) templates
  • Removes xblock_edit_view function and its URL pattern (/xblock/<key>/action/edit)
  • Simplifies container_handler to always redirect to the MFE
  • Cleans up related legacy tests

What was kept (MFE still needs these)

  • container_embed_handler and /container_embed/<usage_key> URL — used by the MFE to load xblock content in iframes
  • container_chromeless.html template — rendered for those MFE iframes
  • use_new_unit_page serializer field — hardcoded True; MFE still reads it from the waffle flags API

Future cleanup (tracked in dev memory)

  • Group 1 (once MFE drops use_new_unit_page from API): remove use_new_unit_page() from toggles.py and the serializer field/method
  • Group 2 (once MFE replaces iframe-based xblock loading): remove container_embed_handler and its entire JS/template stack

References:
#2539
#35587
#36495

Test plan

  • Visit a unit page in Studio — confirm redirect to MFE unit editor
  • Confirm xblock components load correctly inside the MFE unit page (via container_embed_handler iframes)
  • Confirm adding/removing components on the unit page works
  • Run CMS tests: pytest cms/djangoapps/contentstore/ --ds=cms.envs.test

🤖 Generated with Claude Code

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 13, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

The legacy unit editor (controlled by LEGACY_STUDIO_UNIT_EDITOR waffle
flag) has been fully removed. The MFE-based unit editor (frontend-app-
authoring) is now the only editor and is always active.

Removed:
- LEGACY_STUDIO_UNIT_EDITOR CourseWaffleFlag
- container_handler legacy Django-rendered path (now always redirects to MFE)
- xblock_edit_view and xblock_edit_handler URL (/xblock/<key>/action/edit)
- container.html and container_editor.html templates
- unit_outline_spec.js and related legacy tests

Kept (still used by MFE):
- container_embed_handler and /container_embed/<key> URL
- container_chromeless.html template (rendered for MFE iframes)
- use_new_unit_page serializer field (hardcoded True; MFE still reads it)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@salman2013
salman2013 force-pushed the salman/remove-legacy-unit-editor branch from 717835e to 2d87434 Compare August 13, 2026 13:00
@salman2013 salman2013 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants