Skip to content

chore: Upgrade xblocks-contrib to v1.0.4 - #38988

Open
kdmccormick wants to merge 1 commit into
masterfrom
kdmccormick/xblocks-contrib-1.0.4
Open

chore: Upgrade xblocks-contrib to v1.0.4#38988
kdmccormick wants to merge 1 commit into
masterfrom
kdmccormick/xblocks-contrib-1.0.4

Conversation

@kdmccormick

Copy link
Copy Markdown
Member

@kdmccormick

Copy link
Copy Markdown
Member Author

This is failing because openedx-platform relies on test code from xblocks-core, and we stopped publishing xblocks-core tests between these two versions. Quick Claude discovery, will come back to this later.

⏺ Two test modules are imported directly, plus one pulled in transitively. All are under
  xblocks_contrib/problem/capa/tests/ — no other package's test code is touched.

  1. xblocks_contrib.problem.capa.tests.response_xml_factory — 16 call sites

  Imports: CodeResponseXMLFactory, CustomResponseXMLFactory, MultipleChoiceResponseXMLFactory,
  OptionResponseXMLFactory, SchematicResponseXMLFactory, StringResponseXMLFactory

  lms/djangoapps/ccx/tests/test_views.py
  lms/djangoapps/courseware/tests/test_block_render.py
  lms/djangoapps/courseware/tests/test_entrance_exam.py
  lms/djangoapps/courseware/tests/test_masquerade.py
  lms/djangoapps/courseware/tests/test_submitting_problems.py
  lms/djangoapps/courseware/tests/test_views.py
  lms/djangoapps/grades/rest_api/v1/tests/test_grading_policy_view.py
  lms/djangoapps/grades/tests/base.py
  lms/djangoapps/grades/tests/integration/test_access.py
  lms/djangoapps/grades/tests/integration/test_events.py
  lms/djangoapps/grades/tests/integration/test_problems.py
  lms/djangoapps/instructor/tests/test_enrollment.py
  lms/djangoapps/instructor/tests/test_spoc_gradebook.py
  lms/djangoapps/instructor_task/tests/test_base.py
  lms/djangoapps/instructor_task/tests/test_integration.py
  lms/djangoapps/instructor_task/tests/test_tasks_helper.py

  Notably this one has no xblocks_contrib-internal dependencies at all — it only needs abc, six, and lxml. It's
  a pure XML-builder library that happens to live in a tests dir.

  in a tests dir.

  2. xblocks_contrib.problem.capa.tests.test_util — 3 call sites

  Imports: UseUnsafeCodejail

  lms/djangoapps/courseware/tests/test_submitting_problems.py
  lms/djangoapps/instructor_task/tests/test_integration.py
  xmodule/tests/test_capa_block.py

  3. xblocks_contrib.problem.capa.tests.helpers — transitive

  Not imported by platform code directly, but test_util does from ...tests.helpers import mock_capa_system at module scope, so importing UseUnsafeCodejail drags
  it in. helpers in turn reaches into non-test capa internals (capa_problem.LoncapaProblem/LoncapaSystem, inputtypes.Status).

  Also worth flagging: importing test_util means importing a module whose name starts with test_, which pytest collection can pick up — and it contains actual
  unittest/ddt test classes alongside UseUnsafeCodejail.

  Search coverage: I grepped *.py plus all non-Python file types across the repo (excluding node_modules/.git) for xblocks_contrib...test, and separately
  checked for the from xblocks_contrib.foo import tests form and mock.patch string targets. Nothing else surfaced — every other xblocks_contrib reference in the
  platform points at production modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant