-
-
Notifications
You must be signed in to change notification settings - Fork 50
Update migration guide and test docs #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2d40205
Fix typo in filename
PGijsbers 9ec34b3
Update the migration guide with a note on RFC9457 and HTTP codes
PGijsbers eee5760
Small comment on the use of the database in tests
PGijsbers 51929e8
fix typo
PGijsbers d8d0346
fix typos
PGijsbers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the known migration-test limitation for auth failure paths.
This section should mention that some authentication-failure scenarios cannot be asserted through migration tests when the PHP side returns XML instead of JSON, and should be covered in Python unit tests post-migration.
Suggested doc addition
Based on learnings: Migration tests for OpenML API endpoints that rely on php_api for data staging cannot test authentication failure paths (Code 103) when the legacy PHP API returns XML instead of JSON; these paths should be tested in standard Python unit tests after dependent endpoints are migrated.
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[style] ~147-~147: As an alternative to the over-used intensifier ‘extremely’, consider replacing this phrase.
Context: ...re not visible to PHP. In this case, be extremely careful! You must write the test so that even...
(EN_WEAK_ADJECTIVE)
[style] ~148-~148: Consider using “who” when you are referring to a person instead of an object.
Context: ...king, you want to use a context manager that cleans up after you. In some cases you ...
(THAT_WHO)
🤖 Prompt for AI Agents