Skip to content

Add metric preprocessing tasks - #144

Merged
ghar1821 merged 8 commits into
mainfrom
add_preprocessing_tasks
Oct 20, 2026
Merged

ghar1821 merged 8 commits into
mainfrom
add_preprocessing_tasks

Conversation

@ghar1821

@ghar1821 ghar1821 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

Add dataset specific scripts to precompute some commonly used stuff in some metrics. This is so each metric run does not need to recompute them.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@ghar1821
ghar1821 requested a review from rcannood October 12, 2026 13:56
@ghar1821

Copy link
Copy Markdown
Contributor Author

@rcannood the 3 metrics used the precompute information will fail because the precomputed h5ad test files are not in aws bucket. Let me know how to best fix this. I can generate them locally and upload them to the aws bucket.

@rcannood rcannood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the CI tests pass

@ghar1821
ghar1821 merged commit 132e9e2 into main Oct 20, 2026
7 checks passed
@rcannood
rcannood deleted the add_preprocessing_tasks branch October 20, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants