Skip to content

wip: feat: add instructions for shutdown cronjob#43

Closed
jaypoulz wants to merge 1 commit into
openshift-eng:mainfrom
jaypoulz:cron
Closed

wip: feat: add instructions for shutdown cronjob#43
jaypoulz wants to merge 1 commit into
openshift-eng:mainfrom
jaypoulz:cron

Conversation

@jaypoulz
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@openshift-ci openshift-ci Bot requested review from eggfoobar and fonta-rh January 13, 2026 15:09
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
Copy link
Copy Markdown
Contributor

@fonta-rh fonta-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! I'd just update the instruction commands so the script works from the path where there setup is run from automatically

Comment thread cron/shutdown-cluster.sh
ORIGINAL_DIR=$(pwd)

# Change to deploy directory
cd "$HOME/Projects/jaypoulz/two-node-toolbox/deploy" || {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need $USER here? Or maybe we set this path as part of the setup instructions commands?

@jaypoulz jaypoulz marked this pull request as draft April 30, 2026 19:40
@jaypoulz
Copy link
Copy Markdown
Contributor Author

jaypoulz commented May 1, 2026

closing until I have a chance to get back to this

@jaypoulz jaypoulz closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants