WIP: CRD Management Knob Promotion

[gcs278]

Promote GatewayAPIManagementMode to GA.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0b06e5a4-701a-4d4d-bc7b-44e30d1799dc

📥 Commits

Reviewing files that changed from the base of the PR and between 6733660 and e0a4f7f.

⛔ Files ignored due to path filters (1)

• operator/v1alpha1/zz_generated.crd-manifests/0000_50_ingress_02_ingresses.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (7)

• features.md
• features/features.go
• payload-manifests/crds/0000_50_ingress_02_ingresses.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

💤 Files with no reviewable changes (1)

• payload-manifests/crds/0000_50_ingress_02_ingresses.crd.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change enables GatewayAPIManagementMode in the feature matrix and Go feature declaration for all listed profiles. Four 4.10 feature-gate manifests move it from disabled to enabled lists. The Ingress CRD no longer has the release.openshift.io/feature-set annotation.

Suggested reviewers: vr4manta, djoshy, patrickdillon

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to e0a4f

GatewayAPIManagementMode is consistently promoted across the declared profiles and supplied manifests, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the promotion of the CRD management knob, which matches the main change to promote GatewayAPIManagementMode to GA. The WIP prefix adds minor noise but does not make the title uncl…
Description check	✅ Passed	The description directly states that GatewayAPIManagementMode is promoted to GA, which matches the pull request changes and objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The authoritative PR diff changes feature-gate Go configuration, Markdown, and YAML manifests only. It changes no test files and adds or removes no Ginkgo test-title calls such as It(), Describe…
Test Structure And Quality	✅ Passed	The check is not applicable. The authoritative PR diff changes feature-gate declarations, feature matrices, manifests, and CRD annotations only. It adds or modifies no Ginkgo test code, It blocks, res…
Microshift Test Compatibility	✅ Passed	The pull request changes only feature documentation, feature-gate declarations/manifests, and CRD manifests. The authoritative diff contains no new or modified Ginkgo e2e test files and no test bodies…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests. The authoritative diff changes feature metadata, CRD annotations, and feature-gate manifests only. No changed file contains test code or new It(), Desc…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR changes only feature-gate registrations, feature-gate manifests, the feature matrix, and two generated Ingress CRD annotations. The authoritative diff adds or removes no Deployment, pod, …
Ote Binary Stdout Contract	✅ Passed	PASS. The authoritative PR diff changes only feature-gate metadata, generated CRD metadata, and YAML/Markdown feature manifests. The only Go change is the enable(...) argument list in `features/feat…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds no Ginkgo e2e tests. The authoritative diff changes feature-gate declarations, manifests, documentation, and CRD annotations only. Added lines contain feature-gate entries, and n…
No-Weak-Crypto	✅ Passed	PASS. The reviewed diff changes feature-gate defaults, feature-matrix placement, and CRD annotations. It adds no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code. Th…
Container-Privileges	✅ Passed	The pull request changes feature-gate registration, FeatureGate data, and CRD annotations. The changed YAML resources are FeatureGate objects and a CustomResourceDefinition, not Pod or container manif…
No-Sensitive-Data-In-Logs	✅ Passed	The authoritative diff contains only feature-gate declarations and manifests plus CRD annotation removals. It adds no logging calls, log messages, or logged values. Source tracing found no changed log…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/cluster-ingress-operator#1547
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.1-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/49a8adc0-ae3f-11f1-9f24-06da1cf685c8-0