OCPBUGS-99492: NetworkPolicies should use numeric ports instead of named ports by dobsonj · Pull Request #720 · openshift/cluster-storage-operator

dobsonj · 2026-07-24T14:58:04Z

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Summary by CodeRabbit

Bug Fixes
- Updated DNS egress network rules to explicitly allow TCP and UDP traffic on port 5353.
- Improved DNS resolution compatibility by switching from named/non-numeric DNS port entries to the standard numeric 5353 port.

openshift-merge-bot · 2026-07-24T14:58:06Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-07-24T14:58:08Z

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-07-24T14:58:10Z

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-24T14:58:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4dc07af8-e4ce-4b34-830e-82f94f5e2024

📥 Commits

Reviewing files that changed from the base of the PR and between a530735 and 7953709.

📒 Files selected for processing (2)

manifests/09_network-policy-allow-to-dns.yaml
manifests/09_network-policy-cso-allow-to-dns.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

manifests/09_network-policy-cso-allow-to-dns.yaml

Walkthrough

Both DNS egress NetworkPolicies now explicitly allow TCP and UDP traffic on numeric port 5353 instead of named DNS port values.

Changes

DNS egress policy updates

Layer / File(s)	Summary
Use numeric DNS port 5353 `manifests/09_network-policy-allow-to-dns.yaml`, `manifests/09_network-policy-cso-allow-to-dns.yaml`	Both manifests specify port `5353` for TCP and UDP DNS egress rules.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: replacing named DNS ports with numeric ports in NetworkPolicies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes two YAML manifests; no Ginkgo test files or titles were added or modified.
Test Structure And Quality	✅ Passed	PR only changes two YAML manifests; no Ginkgo tests or cluster-interaction code were added or modified, so the test-structure checklist is not applicable.
Microshift Test Compatibility	✅ Passed	Only two NetworkPolicy manifests changed; no new Ginkgo tests or unsupported MicroShift APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes NetworkPolicy manifests; no new Ginkgo tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only two NetworkPolicy manifests changed; they adjust DNS ports and add no scheduling, affinity, replica, or topology constraints.
Ote Binary Stdout Contract	✅ Passed	Only two manifest files changed; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only two NetworkPolicy manifests changed; no Ginkgo/e2e tests or connectivity assumptions were added.
No-Weak-Crypto	✅ Passed	The PR only changes two NetworkPolicy YAML manifests; no crypto code or secret comparisons were added, and touched files contain no weak-crypto indicators.
Container-Privileges	✅ Passed	Changed manifests are NetworkPolicies only; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs	✅ Passed	Only NetworkPolicy manifest ports changed; no logging code or sensitive fields/data appears in the touched files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-07-24T14:58:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dobsonj · 2026-07-24T14:59:46Z

/jira refresh

openshift-ci-robot · 2026-07-24T14:59:52Z

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dobsonj · 2026-07-24T16:33:37Z

/retest

dobsonj · 2026-07-27T15:49:40Z

/retest

jsafrane · 2026-07-28T13:42:07Z

/lgtm

openshift-merge-bot · 2026-07-28T13:46:18Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-gcp-csi
/test e2e-vsphere-csi

dobsonj · 2026-07-28T18:04:06Z

/retest

…med ports

dobsonj · 2026-07-28T20:33:30Z

/pipeline required

openshift-merge-bot · 2026-07-28T20:33:33Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-gcp-csi
/test e2e-vsphere-csi

openshift-ci-robot · 2026-07-28T20:33:37Z

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Summary by CodeRabbit

Bug Fixes

Updated DNS egress network rules to explicitly allow TCP and UDP traffic on port 5353.

Improved DNS resolution compatibility by switching from named/non-numeric DNS port entries to the standard numeric 5353 port.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dobsonj · 2026-07-28T20:40:22Z

Apparently coredns uses port 5353:
https://github.com/openshift/cluster-dns-operator/blob/4b8ae49940eefc50fa48da5179e735dd6ccd42d9/pkg/manifests/assets/dns/daemonset.yaml#L28-L33
https://github.com/openshift/cluster-dns-operator/blob/4b8ae49940eefc50fa48da5179e735dd6ccd42d9/pkg/manifests/assets/dns/networkpolicy-allow.yaml#L13-L17

dobsonj · 2026-07-28T22:44:03Z

The e2e-*-csi jobs passed after changing the port number from 53 to 5353
/verified by CI

openshift-ci-robot · 2026-07-28T22:44:16Z

@dobsonj: This PR has been marked as verified by CI.

Details

In response to this:

The e2e-*-csi jobs passed after changing the port number from 53 to 5353
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dobsonj · 2026-07-28T23:30:03Z

/retest

RomanBednar · 2026-07-29T15:17:07Z

/lgtm

openshift-merge-bot · 2026-07-29T15:17:45Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-gcp-csi
/test e2e-vsphere-csi

openshift-ci · 2026-07-29T18:24:48Z

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-07-29T18:29:10Z

@dobsonj: Jira Issue OCPBUGS-99492: Some pull requests linked via external trackers have merged:

openshift/cluster-storage-operator#720

The following pull request, linked via external tracker, has not merged:

openshift/origin#31429 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-99492 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Summary by CodeRabbit

Bug Fixes

Updated DNS egress network rules to explicitly allow TCP and UDP traffic on port 5353.

Improved DNS resolution compatibility by switching from named/non-numeric DNS port entries to the standard numeric 5353 port.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-08-09T01:55:01Z

Fix included in release 5.0.0-0.nightly-2026-08-08-200126

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 24, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026

dobsonj mentioned this pull request Jul 24, 2026

OCPBUGS-99492: remove storage NetworkPolicies from validation skip list openshift/origin#31429

Merged

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 24, 2026

openshift-ci Bot assigned jsafrane Jul 28, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2026

openshift-ci Bot assigned radeore Jul 28, 2026

OCPBUGS-99492: NetworkPolicies should use numeric ports instead of na…

7953709

…med ports

dobsonj force-pushed the OCPBUGS-99492 branch from a530735 to 7953709 Compare July 28, 2026 20:32

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 28, 2026

openshift-ci Bot assigned RomanBednar Jul 29, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2026

openshift-merge-bot Bot merged commit f3f8e3f into openshift:main Jul 29, 2026
17 checks passed

Conversation

dobsonj commented Jul 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

openshift-ci-robot commented Jul 24, 2026

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

dobsonj commented Jul 24, 2026

Uh oh!

openshift-ci-robot commented Jul 24, 2026

Uh oh!

dobsonj commented Jul 24, 2026

Uh oh!

dobsonj commented Jul 27, 2026

Uh oh!

jsafrane commented Jul 28, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 28, 2026

Uh oh!

dobsonj commented Jul 28, 2026

Uh oh!

dobsonj commented Jul 28, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 28, 2026

Uh oh!

openshift-ci-robot commented Jul 28, 2026

Summary by CodeRabbit

Uh oh!

dobsonj commented Jul 28, 2026

Uh oh!

dobsonj commented Jul 28, 2026

Uh oh!

openshift-ci-robot commented Jul 28, 2026

Uh oh!

dobsonj commented Jul 28, 2026

Uh oh!

RomanBednar commented Jul 29, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 29, 2026

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dobsonj commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading