Skip to content

OTA-2109: harden console plugin nginx TLS configuration - #1453

Open
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:fix/nginx-tls-hardening-OTA-2109
Open

OTA-2109: harden console plugin nginx TLS configuration#1453
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:fix/nginx-tls-hardening-OTA-2109

Conversation

@jrangelramos

Copy link
Copy Markdown
Member

Summary

  • Add explicit ssl_protocols, ssl_ciphers, ssl_prefer_server_ciphers, and server_tokens off to the console plugin nginx server block
  • The config previously relied on UBI 9 compile-time defaults which are safe, but making them explicit improves auditability and guards against future default changes
  • Security headers (X-Frame-Options, CSP, etc.) intentionally omitted — this nginx serves JS/CSS bundles fetched by the console proxy, not HTML documents

JIRA

https://redhat.atlassian.net/browse/OTA-2109

Test plan

  • Verify make build succeeds
  • Verify make verify passes
  • Deploy on a test cluster with agentic updates enabled and confirm the console plugin pod starts and serves assets over TLS

🤖 Generated with Claude Code

Add explicit ssl_protocols, ssl_ciphers, ssl_prefer_server_ciphers,
and server_tokens off to the console plugin nginx server block.
The config previously relied on UBI 9 compile-time defaults which
are safe, but making them explicit improves auditability and guards
against future default changes.

https://redhat.atlassian.net/browse/OTA-2109

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 19, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: This pull request references OTA-2109 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the weakness to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add explicit ssl_protocols, ssl_ciphers, ssl_prefer_server_ciphers, and server_tokens off to the console plugin nginx server block
  • The config previously relied on UBI 9 compile-time defaults which are safe, but making them explicit improves auditability and guards against future default changes
  • Security headers (X-Frame-Options, CSP, etc.) intentionally omitted — this nginx serves JS/CSS bundles fetched by the console proxy, not HTML documents

JIRA

https://redhat.atlassian.net/browse/OTA-2109

Test plan

  • Verify make build succeeds
  • Verify make verify passes
  • Deploy on a test cluster with agentic updates enabled and confirm the console plugin pod starts and serves assets over TLS

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jrangelramos, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e09fd6e7-f45a-46b2-af11-0d3b0c79e56d

📥 Commits

Reviewing files that changed from the base of the PR and between 208b01a and 6dea9cd.

📒 Files selected for processing (1)
  • pkg/agenticrun/bindata/assets/configmap.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign davidhurta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants