OCPBUGS-95593: show OCP version in About modal for non-admin users - #16987
OCPBUGS-95593: show OCP version in About modal for non-admin users#16987savio87 wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@savio87: This pull request references Jira Issue OCPBUGS-95593, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: savio87 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe About modal now uses ChangesAbout modal version display
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The About modal now has a fallback that lets non-admin users see the OpenShift version while preserving the existing admin update-state behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @savio87. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@savio87: This pull request references Jira Issue OCPBUGS-95593, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@savio87: This pull request references Jira Issue OCPBUGS-95593, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Fixes OCPBUGS-95593: Non-admin users see only the Kubernetes version in the About modal ("?" > "About"), but not the OpenShift version.
The About modal uses
useClusterVersion()which watches theClusterVersionresource via the K8s API. Non-admin users lack RBAC access to this resource, so the hook returns null and the OpenShift version is hidden.The fix falls back to
window.SERVER_FLAGS.releaseVersion, which is set by the console backend at startup and is available to all users regardless of RBAC. This pattern is already used elsewhere in the codebase (e.g.useTelemetry.ts).Test plan
ClusterVersionresource (with "Updating to..." state awareness)SERVER_FLAGS.releaseVersionSummary by CodeRabbit