Skip to content

Fix Cypress test casing to match sentence-case UI labels - #17000

Draft
sowmya-sl wants to merge 1 commit into
openshift:mainfrom
sowmya-sl:fix-cypress-helm-casing
Draft

Fix Cypress test casing to match sentence-case UI labels#17000
sowmya-sl wants to merge 1 commit into
openshift:mainfrom
sowmya-sl:fix-cypress-helm-casing

Conversation

@sowmya-sl

@sowmya-sl sowmya-sl commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Update Helm Cypress E2E test selectors, constants, and assertions to use sentence case ("Helm release", "Helm releases") matching the current UI labels. The source code was updated to sentence case but the Cypress tests still referenced title case, causing test failures.

Analysis / Root cause:

Solution description:

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Summary by CodeRabbit

  • Style

    • Standardized Helm UI terminology to use consistent lowercase “release” and “releases” wording across page titles, menus, empty states, actions, and topology labels.
  • Tests

    • Updated automated coverage to reflect the revised Helm terminology, including navigation, release details, upgrade flows, deletion actions, and topology display options.

Update Helm Cypress E2E test selectors, constants, and assertions to
use sentence case ("Helm release", "Helm releases") matching the
current UI labels. The source code was updated to sentence case but
the Cypress tests still referenced title case, causing test failures.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 589fe4c3-4095-4cca-94b3-869cbc1aeedd

📥 Commits

Reviewing files that changed from the base of the PR and between 83eb732 and d11e0ce.

📒 Files selected for processing (12)
  • frontend/packages/dev-console/integration-tests/support/constants/helm.ts
  • frontend/packages/dev-console/integration-tests/support/constants/pageTitle.ts
  • frontend/packages/dev-console/integration-tests/support/constants/staticText/global-text.ts
  • frontend/packages/dev-console/integration-tests/support/constants/topology.ts
  • frontend/packages/dev-console/integration-tests/support/pageObjects/helm-po.ts
  • frontend/packages/helm-plugin/integration-tests/support/constants/static-text/helm-text.ts
  • frontend/packages/helm-plugin/integration-tests/support/pages/helm/helm-details-page.ts
  • frontend/packages/helm-plugin/integration-tests/support/pages/helm/helm-page.ts
  • frontend/packages/helm-plugin/integration-tests/support/pages/helm/upgrade-helm-release-page.ts
  • frontend/packages/helm-plugin/integration-tests/support/step-definitions/helm/helm-navigation.ts
  • frontend/packages/helm-plugin/integration-tests/support/step-definitions/helm/helm-release.ts
  • frontend/packages/topology/integration-tests/support/pages/topology/topology-page.ts

Walkthrough

The change standardizes Helm release capitalization across Dev Console and Helm plugin integration-test constants, selectors, page assertions, navigation steps, and topology selectors.

Changes

Helm release label alignment

Layer / File(s) Summary
Shared Helm release labels
frontend/packages/dev-console/integration-tests/support/constants/*, frontend/packages/helm-plugin/integration-tests/support/constants/*
Updated Helm release titles, messages, topology labels, and action constants to use lowercase “release”.
Integration-test selectors and assertions
frontend/packages/dev-console/integration-tests/support/pageObjects/helm-po.ts, frontend/packages/helm-plugin/integration-tests/support/pages/helm/*, frontend/packages/helm-plugin/integration-tests/support/step-definitions/helm/*, frontend/packages/topology/integration-tests/support/pages/topology/topology-page.ts
Updated selectors, menu actions, modal titles, page assertions, navigation steps, tab IDs, and topology selectors to match the revised labels.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d11e0

This localized change updates Cypress selectors and assertions to match the current sentence-case Helm UI labels; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the root cause and solution, but all required template sections remain incomplete, including test cases and browser conformance. Complete the required sections with testing details, test cases, browser coverage, screenshots if applicable, and reviewer or assignee information.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating Cypress test casing to match sentence-case UI labels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff only changes static Helm label casing in Cypress/Cucumber support files; it adds no Ginkgo test titles or dynamic values.
Test Structure And Quality ✅ Passed The diff changes only 12 TypeScript Cypress support files and sentence-case strings; it adds no Ginkgo tests, cluster operations, waits, or assertions covered by this check.
Microshift Test Compatibility ✅ Passed The pull-request diff contains only 12 TypeScript Cypress support files; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only existing TypeScript Cypress selectors, constants, and step definitions; the diff adds no Ginkgo It/Describe/Context/When tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR diff changes only 12 TypeScript Cypress integration-test support files and only Helm label strings; it adds no manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff changes only 12 TypeScript Cypress support files; it adds no OTE binary, suite-setup, or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only 12 TypeScript Cypress constants, selectors, and assertions; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The diff contains only Helm UI test-label and selector case changes; added-line and changed-directory scans found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or crypto comparisons.
Container-Privileges ✅ Passed The diff only changes Helm test strings and dependency resolutions; no added manifest or code settings include privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The commit only changes Helm UI strings and Cypress selectors. The added lines contain no logging calls, sensitive values, or sensitive-data interpolation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sowmya-sl
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/dev-console Related to dev-console component/helm Related to helm-plugin component/topology Related to topology needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dev-console Related to dev-console component/helm Related to helm-plugin component/topology Related to topology do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant