Skip to content

USHIFT-7446: Ansible: add MicroShift 5.0 pod counts - #7187

Open
sjug wants to merge 1 commit into
openshift:mainfrom
sjug:ushift-7446-pod-counts
Open

USHIFT-7446: Ansible: add MicroShift 5.0 pod counts#7187
sjug wants to merge 1 commit into
openshift:mainfrom
sjug:ushift-7446-pod-counts

Conversation

@sjug

@sjug sjug commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Add MicroShift 5.0 boot-readiness thresholds to the Ansible version map.

This prevents 5.0 source builds from failing before boot measurement and unblocks follow-up pull-request performance work in USHIFT-7441.

Testing

  • Loaded ansible/vars/microshift_versions.yml with ansible-inventory
  • ansible-playbook --syntax-check setup-node.yml
  • ansible-lint --profile min vars/microshift_versions.yml
  • git diff --check
  • Live MicroShift 5.0 deployment from current main on RHEL 9.8: service active, API ready, node Ready, six running core non-storage pods, and nine Ready core pods

Issue

https://issues.redhat.com/browse/USHIFT-7446

Summary by CodeRabbit

  • New Features
    • Added configuration support for MicroShift version 5.0.
    • Updated expected pod counts for this version: 6 expected pods and 9 total pods.

Add the version-specific readiness thresholds needed by the Ansible
boot measurement for MicroShift 5.0 source builds.

The values match a live 5.0 deployment with six running non-storage
pods and nine ready core pods.

Signed-off-by: Sebastian Jug <seb@stianj.ug>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 13, 2026

Copy link
Copy Markdown

@sjug: This pull request references USHIFT-7446 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add MicroShift 5.0 boot-readiness thresholds to the Ansible version map.

This prevents 5.0 source builds from failing before boot measurement and unblocks follow-up pull-request performance work in USHIFT-7441.

Testing

  • Loaded ansible/vars/microshift_versions.yml with ansible-inventory
  • ansible-playbook --syntax-check setup-node.yml
  • ansible-lint --profile min vars/microshift_versions.yml
  • git diff --check
  • Live MicroShift 5.0 deployment from current main on RHEL 9.8: service active, API ready, node Ready, six running core non-storage pods, and nine Ready core pods

Issue

https://issues.redhat.com/browse/USHIFT-7446

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 160b78c9-5a7d-4122-b14c-4d8547f5e718

📥 Commits

Reviewing files that changed from the base of the PR and between c60850e and fbad76c.

📒 Files selected for processing (1)
  • ansible/vars/microshift_versions.yml

Walkthrough

The version configuration adds MicroShift 5.0 with an expected pod count of 6 and a total pod count of 9.

Changes

MicroShift version configuration

Layer / File(s) Summary
Add MicroShift 5.0 pod counts
ansible/vars/microshift_versions.yml
Adds expected pod count 6 and total pod count 9 for MicroShift 5.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to fbad7

This localized version-map update adds MicroShift 5.0 boot-readiness thresholds, and no actionable merge-blocking risk remains after normal checks and review.

Suggested labels: ready-for-human-review

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Ansible change and the addition of MicroShift 5.0 pod counts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only ansible/vars/microshift_versions.yml by adding static pod-count data; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The commit changes only ansible/vars/microshift_versions.yml by adding version data; it introduces no Ginkgo It block or cluster test operation subject to this check.
Microshift Test Compatibility ✅ Passed The parent diff changes only ansible/vars/microshift_versions.yml and adds no Ginkgo e2e tests, so this compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch changes only ansible/vars/microshift_versions.yml by adding MicroShift 5.0 pod counts; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The HEAD diff changes only ansible/vars/microshift_versions.yml by adding pod-count data; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only Ansible YAML pod-count data. No OTE binary process code or process-level stdout writes were added or changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch adds only three YAML version-count lines; it adds no Ginkgo e2e test and no IPv4 or external-connectivity requirement.
No-Weak-Crypto ✅ Passed The verified diff adds only the quoted 5.0 version key and pod-count integers; it introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or secret comparison.
Container-Privileges ✅ Passed The only changed file adds MicroShift 5.0 pod-count values; the patch adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or privilege-escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only numeric pod-count values for MicroShift 5.0; the consumer passes them to readiness checks and logs no passwords, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from agullon and jerpeter1 August 13, 2026 18:44
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjug
Once this PR has been reviewed and has the lgtm label, please assign copejon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@sjug: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-unit fbad76c link true /test test-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants