Skip to content

CONSOLE-5276: Add console-plugin-demo dependency to e2e-playwright job#80878

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rhamilto:CONSOLE-5276
Jun 23, 2026
Merged

CONSOLE-5276: Add console-plugin-demo dependency to e2e-playwright job#80878
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rhamilto:CONSOLE-5276

Conversation

@rhamilto

@rhamilto rhamilto commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Add console-plugin-demo image dependency to the e2e-playwright CI job
  • Maps to PLUGIN_PULL_SPEC env var (the Cypress job uses CYPRESS_PLUGIN_PULL_SPEC — the CYPRESS_ prefix is Cypress-specific)
  • Enables demo dynamic plugin tests to run in the Playwright CI job

Companion PR

Test plan

  • Verify e2e-playwright job picks up the console-plugin-demo image and sets PLUGIN_PULL_SPEC
  • Verify demo plugin tests no longer skip in CI

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR updates the OpenShift Console repository's CI configuration to add the console-plugin-demo image as a dependency to the e2e-playwright job. The change injects the PLUGIN_PULL_SPEC environment variable (sourced from the console-plugin-demo image) into the Playwright end-to-end test step.

This modification enables the Playwright CI environment to access the demo dynamic plugin image, which is necessary to support demo plugin tests that were recently migrated from Cypress to Playwright in the main OpenShift Console repository. The configuration change aligns the Playwright job with similar dependency injection patterns used in other CI workflows, ensuring the plugin image is available during test execution.

Changed files:

  • ci-operator/config/openshift/console/openshift-console-main.yaml (+3 lines)

Related issue: CONSOLE-5276

Add the console-plugin-demo image dependency to the e2e-playwright CI
job so the demo dynamic plugin tests can deploy and test the plugin.
Uses PLUGIN_PULL_SPEC (without the CYPRESS_ prefix used by the Cypress
job) since Playwright reads process.env directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references CONSOLE-5276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add console-plugin-demo image dependency to the e2e-playwright CI job
  • Maps to PLUGIN_PULL_SPEC env var (the Cypress job uses CYPRESS_PLUGIN_PULL_SPEC — the CYPRESS_ prefix is Cypress-specific)
  • Enables demo dynamic plugin tests to run in the Playwright CI job

Companion PR

Test plan

  • Verify e2e-playwright job picks up the console-plugin-demo image and sets PLUGIN_PULL_SPEC
  • Verify demo plugin tests no longer skip in CI

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

In the CI operator config for openshift-console-main, a dependencies block is added to the e2e-playwright optional GCP test step. It maps the console-plugin-demo image to the PLUGIN_PULL_SPEC environment variable within that step.

Changes

e2e-playwright Dependency Injection

Layer / File(s) Summary
Add PLUGIN_PULL_SPEC dependency to e2e-playwright step
ci-operator/config/openshift/console/openshift-console-main.yaml
Adds a dependencies entry that sets PLUGIN_PULL_SPEC from the console-plugin-demo image in the e2e-playwright test step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically identifies the main change: adding the console-plugin-demo dependency to the e2e-playwright job. It directly matches the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only CI configuration YAML files, not test code. No Ginkgo test definitions (It(), Describe(), Context(), When()) are present. The custom check for stable test names is not applicab...
Test Structure And Quality ✅ Passed This PR modifies CI configuration (YAML) and utility test files, not Ginkgo test code. The custom check requires reviewing Ginkgo test code, making it not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR only modifies CI configuration (adds image dependency to e2e-playwright job); no new Ginkgo tests are added. Check applicability: "When new Ginkgo e2e tests are added" - this condition is n...
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies CI configuration (YAML) in the openshift/release repository and does not add any new Ginkgo e2e tests. The check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI test configuration only, not deployment manifests or operator code. No scheduling constraints, topology assumptions, or affinity rules are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML file to add environment variable dependency; no executable code or stdout writes present in changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only CI configuration (YAML), not adding new Ginkgo e2e tests. The custom check applies only to new Ginkgo tests, making it inapplicable here.
No-Weak-Crypto ✅ Passed PR modifies only CI/CD YAML configuration to add image dependency; no cryptographic code or weak crypto patterns introduced.
Container-Privileges ✅ Passed The PR modifies CI config without any privileged containers, hostPID/Network/IPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation flags. The change only adds a dependency mapping.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data logging introduced. The PR only adds a declarative CI configuration dependency that maps a build artifact image to a non-sensitive environment variable name, with no credentials,...
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett June 22, 2026 22:37
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@rhamilto

Copy link
Copy Markdown
Member Author

/assign @jhadvig

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rhamilto: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-console-main-e2e-playwright openshift/console presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/pj-rehearse auto-ack

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto

Copy link
Copy Markdown
Member Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rhamilto: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhamilto

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rhamilto: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit a9edeee into openshift:main Jun 23, 2026
15 checks passed
@rhamilto rhamilto deleted the CONSOLE-5276 branch June 23, 2026 20:09
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Jun 26, 2026
openshift#80878)

Add the console-plugin-demo image dependency to the e2e-playwright CI
job so the demo dynamic plugin tests can deploy and test the plugin.
Uses PLUGIN_PULL_SPEC (without the CYPRESS_ prefix used by the Cypress
job) since Playwright reads process.env directly.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants