CONSOLE-5276: Add console-plugin-demo dependency to e2e-playwright job#80878
Conversation
Add the console-plugin-demo image dependency to the e2e-playwright CI job so the demo dynamic plugin tests can deploy and test the plugin. Uses PLUGIN_PULL_SPEC (without the CYPRESS_ prefix used by the Cypress job) since Playwright reads process.env directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@rhamilto: This pull request references CONSOLE-5276 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughIn the CI operator config for Changese2e-playwright Dependency Injection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/assign @jhadvig |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
|
@rhamilto: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@rhamilto: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift#80878) Add the console-plugin-demo image dependency to the e2e-playwright CI job so the demo dynamic plugin tests can deploy and test the plugin. Uses PLUGIN_PULL_SPEC (without the CYPRESS_ prefix used by the Cypress job) since Playwright reads process.env directly. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
console-plugin-demoimage dependency to thee2e-playwrightCI jobPLUGIN_PULL_SPECenv var (the Cypress job usesCYPRESS_PLUGIN_PULL_SPEC— theCYPRESS_prefix is Cypress-specific)Companion PR
Test plan
e2e-playwrightjob picks up theconsole-plugin-demoimage and setsPLUGIN_PULL_SPEC🤖 Generated with Claude Code
Summary by CodeRabbit
This PR updates the OpenShift Console repository's CI configuration to add the
console-plugin-demoimage as a dependency to thee2e-playwrightjob. The change injects thePLUGIN_PULL_SPECenvironment variable (sourced from theconsole-plugin-demoimage) into the Playwright end-to-end test step.This modification enables the Playwright CI environment to access the demo dynamic plugin image, which is necessary to support demo plugin tests that were recently migrated from Cypress to Playwright in the main OpenShift Console repository. The configuration change aligns the Playwright job with similar dependency injection patterns used in other CI workflows, ensuring the plugin image is available during test execution.
Changed files:
ci-operator/config/openshift/console/openshift-console-main.yaml(+3 lines)Related issue: CONSOLE-5276