USHIFT-7412: Add RPM presubmit Prow job for MicroShift - #83232
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@agullon: This pull request references USHIFT-7412 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughThe change adds an optional AWS RPM presubmit for MicroShift. It maps the ChangesMicroShift RPM presubmit
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift/microshift/infra/iso-build/openshift-microshift-infra-iso-build-commands.sh`:
- Around line 43-46: Replace the temporary GUSR/GBRN checkout in the ISO build
command with the standard ci_clone_src invocation, and remove the associated
TODO comment. Ensure the presubmit clones the intended MicroShift source rather
than the temporary fork and branch.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7100a1dd-bcab-43ff-935f-98da71fa990e
📒 Files selected for processing (1)
ci-operator/step-registry/openshift/microshift/infra/iso-build/openshift-microshift-infra-iso-build-commands.sh
| # TODO: Revert to 'ci_clone_src' before merging | ||
| GUSR=agullon | ||
| GBRN=USHIFT-7412 | ||
| git clone "https://github.com/${GUSR}/microshift.git" -b "${GBRN}" /go/src/github.com/openshift/microshift |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Restore the standard source checkout before merging.
This hard-codes agullon/microshift and branch USHIFT-7412, so the presubmit will build the temporary fork instead of the intended MicroShift source. It can validate code that is not part of this PR and fail when the temporary branch is removed. Restore the ci_clone_src invocation and remove the TODO before merge.
The PR context identifies this checkout as temporary test code that must be reverted before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/openshift/microshift/infra/iso-build/openshift-microshift-infra-iso-build-commands.sh`
around lines 43 - 46, Replace the temporary GUSR/GBRN checkout in the ISO build
command with the standard ci_clone_src invocation, and remove the associated
TODO comment. Ensure the presubmit clones the intended MicroShift source rather
than the temporary fork and branch.
|
@agullon: job(s): e2e-aws-tests-rpm either don't exist or were not found to be affected, and cannot be rehearsed |
Add e2e-aws-tests-rpm job (optional) that runs RPM-based presubmit scenarios. The job downloads installer ISOs from the S3 build cache and builds RPMs from source, skipping the image build phase entirely. Changes: - Add e2e-aws-tests-rpm job to openshift-microshift-main.yaml - Add rpm-presubmits mapping to get_source_dir() - Declare SCENARIO_TYPE env var in iso-build step Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Points iso-build to agullon/microshift USHIFT-7412 branch to test the RPM presubmit job before the microshift PR merges. Revert this commit before merging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
46d08d4 to
7443de5
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 395 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@agullon: job(s): e2e-aws-tests-rpm either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: your |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: your |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: your |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: your |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: your |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-rpm |
|
@agullon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing — RPM scenarios will run in existing CI lines instead of a separate job. |
2 participants
Summary
e2e-aws-tests-rpmjob (optional: true) to MicroShift main configrpm-presubmits→scenarios-rpm/presubmitsinget_source_dir()SCENARIO_TYPEenv var in the iso-build step refCompanion PR
Test plan
/test e2e-aws-tests-rpmon the microshift PR🤖 Generated with Claude Code
Summary by CodeRabbit
c5.metalRPM presubmit job for MicroShift.get_source_dir().SCENARIO_TYPEsupport to MicroShift ISO builds.USHIFT-7412MicroShift source branch.