feat: [ODH] onboard odh-mod-arch-notebooks image build to odh-dashboard - #83433
feat: [ODH] onboard odh-mod-arch-notebooks image build to odh-dashboard#83433harshad16 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe CI configuration adds a notebooks modular-architecture image build and PR and postsubmit image-mirror workflows. ChangesNotebooks image publishing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds image-build configuration for the dashboard project, and no actionable merge-blocking risk remains based on the supplied evidence. Sequence Diagram(s)sequenceDiagram
participant Source as packages/notebooks/
participant CI as CI configuration
participant Registry as Image registry
Source->>CI: Trigger PR workflow on changes
CI->>Registry: Mirror odh-mod-arch-notebooks image
CI->>Registry: Publish postsubmit image with release version main
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d6ba922 to
3429243
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/retest-required |
|
/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-notebooks-pr-image-mirror |
|
@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caponetto, harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest-required |
1 similar comment
|
/retest-required |
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
3429243 to
dc58d2e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
New changes are detected. LGTM label has been removed. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-notebooks-pr-image-mirror |
|
@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@harshad16: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
feat: [ODH] onboard odh-mod-arch-notebooks image build to odh-dashboard
JIRA: https://redhat.atlassian.net/browse/RHOAIENG-58842
Summary by CodeRabbit
odh-mod-arch-notebooksimage build to theodh-dashboardOpenShift CI configuration.packages/notebooks/Dockerfile.workspaceto buildodh-mod-arch-notebooks-image.packages/notebooks/.odh-mod-arch-notebooks:main.