Skip to content

feat: [ODH] onboard odh-mod-arch-notebooks image build to odh-dashboard - #83433

Open
harshad16 wants to merge 1 commit into
openshift:mainfrom
harshad16:onboard-odh-mod-arch-notebooks
Open

feat: [ODH] onboard odh-mod-arch-notebooks image build to odh-dashboard#83433
harshad16 wants to merge 1 commit into
openshift:mainfrom
harshad16:onboard-odh-mod-arch-notebooks

Conversation

@harshad16

@harshad16 harshad16 commented Aug 14, 2026

Copy link
Copy Markdown
Member

feat: [ODH] onboard odh-mod-arch-notebooks image build to odh-dashboard
JIRA: https://redhat.atlassian.net/browse/RHOAIENG-58842

Summary by CodeRabbit

  • Adds the odh-mod-arch-notebooks image build to the odh-dashboard OpenShift CI configuration.
  • Uses packages/notebooks/Dockerfile.workspace to build odh-mod-arch-notebooks-image.
  • Adds pull request and postsubmit image-mirror tests for packages/notebooks/.
  • Publishes the postsubmit image as odh-mod-arch-notebooks:main.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d6dfbda8-448f-496d-8319-60faa9a154e4

📥 Commits

Reviewing files that changed from the base of the PR and between 6b528f0 and dc58d2e.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml

Walkthrough

The CI configuration adds a notebooks modular-architecture image build and PR and postsubmit image-mirror workflows.

Changes

Notebooks image publishing

Layer / File(s) Summary
Build and mirror notebooks image
ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
The configuration builds packages/notebooks/Dockerfile.workspace as odh-mod-arch-notebooks-image. The PR workflow runs when packages/notebooks/ changes. The postsubmit workflow mirrors the image to odh-mod-arch-notebooks with release version main.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dc58d

This change adds image-build configuration for the dashboard project, and no actionable merge-blocking risk remains based on the supplied evidence.

Sequence Diagram(s)

sequenceDiagram
  participant Source as packages/notebooks/
  participant CI as CI configuration
  participant Registry as Image registry
  Source->>CI: Trigger PR workflow on changes
  CI->>Registry: Mirror odh-mod-arch-notebooks image
  CI->>Registry: Publish postsubmit image with release version main
Loading

Suggested reviewers: mturley, andrewballantyne

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes onboarding the odh-mod-arch-notebooks image build to odh-dashboard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only static CI YAML image and mirror job names; no Ginkgo It/Describe/Context/When titles or dynamic test-title values were added.
Test Structure And Quality ✅ Passed The commit changes only CI image-build and image-mirror YAML; it adds no Ginkgo test code or It blocks to assess.
Microshift Test Compatibility ✅ Passed The PR changes only CI YAML files for image builds and mirrors; the parent-to-HEAD diff adds no Ginkgo e2e tests or OpenShift API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The exact PR diff changes only three YAML CI files; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only CI image-build and Prow job configuration; it adds no deployment, operator, controller, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR diff contains only three YAML CI configuration/job files. It adds image build and mirror jobs, with no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR diff adds only image-build and image-mirror YAML entries. It adds no Ginkgo e2e test code, IPv4 assumptions, or external service access.
No-Weak-Crypto ✅ Passed The PR changes only CI YAML for an image build and mirror tests; the complete diff introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The diff adds image and mirror-job configuration only; added YAML contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds only image-build and mirror metadata. Added-line scans found no logging commands or literal credentials, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harshad16
harshad16 force-pushed the onboard-odh-mod-arch-notebooks branch from d6ba922 to 3429243 Compare August 14, 2026 12:24
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@harshad16

Copy link
Copy Markdown
Member Author

/retest-required

@harshad16

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-notebooks-pr-image-mirror

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@caponetto

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caponetto, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2026
@harshad16

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 14, 2026
@harshad16

Copy link
Copy Markdown
Member Author

/retest-required

1 similar comment
@harshad16

Copy link
Copy Markdown
Member Author

/retest-required

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16
harshad16 force-pushed the onboard-odh-mod-arch-notebooks branch from 3429243 to dc58d2e Compare August 14, 2026 17:36
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 14, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@harshad16: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-notebooks-pr-image-mirror opendatahub-io/odh-dashboard presubmit Presubmit changed
pull-ci-opendatahub-io-odh-dashboard-main-images opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-core-bff-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-operator-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-agent-ops-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-automl-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-autorag-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-eval-hub-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-gen-ai-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-maas-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-mlflow-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-model-registry-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@harshad16

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-notebooks-pr-image-mirror

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/config dc58d2e link true /test config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants