HYPERFLEET-1218 - chore: remove helm-git from CI configurations

[ciaranRoche]

What

Remove helm-git plugin from HyperFleet CI configurations in openshift/release.

Changes

• ci-operator/config/.../hyperfleet-infra-main.yaml: Remove helm-git from CI Dockerfile
• ci-operator/step-registry/.../chart-deployment-commands.sh: Remove helm-git installation

Why

HyperFleet charts published to OCI registry (HYPERFLEET-1216). No plugin required for OCI chart consumption.

Testing

CI chart deployment step no longer needs helm-git plugin for OCI chart pulls.

Related

• HYPERFLEET-1218: helm-git Removal Verification Complete
• HYPERFLEET-831: Helm OCI Distribution (epic)

Summary by CodeRabbit

• Removed the unused helm-git plugin from HyperFleet infrastructure CI images and the legacy chart-deployment step.
• HyperFleet chart deployment now relies on OCI registry support.
• Helm Diff installation and all other deployment operations remain unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ea94b3ff-c91c-4588-920b-3dd80806293e

📥 Commits

Reviewing files that changed from the base of the PR and between 17f4133 and e2ff231.

📒 Files selected for processing (2)

• ci-operator/config/openshift-hyperfleet/hyperfleet-infra/openshift-hyperfleet-hyperfleet-infra-main.yaml
• ci-operator/step-registry/openshift-hyperfleet/chart-deployment/openshift-hyperfleet-chart-deployment-commands.sh

💤 Files with no reviewable changes (2)

• ci-operator/config/openshift-hyperfleet/hyperfleet-infra/openshift-hyperfleet-hyperfleet-infra-main.yaml
• ci-operator/step-registry/openshift-hyperfleet/chart-deployment/openshift-hyperfleet-chart-deployment-commands.sh

---

Walkthrough

The build image and chart deployment script no longer install or list the helm-git plugin. Helm Diff installation and later deployment steps remain unchanged.

Changes

Helm plugin cleanup

Layer / File(s)	Summary
Remove helm-git setup ci-operator/config/openshift-hyperfleet/hyperfleet-infra/..., ci-operator/step-registry/openshift-hyperfleet/chart-deployment/...	The build image retains Helm Diff installation. The deployment script no longer installs or lists helm-git.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e2ff2

This change removes an unnecessary helm-git dependency from CI now that charts use OCI distribution; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the removal of helm-git from HyperFleet CI configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch only removes helm-git installation commands from YAML and a shell script; it changes no Ginkgo test titles or test code.
Test Structure And Quality	✅ Passed	The diff changes only two CI YAML/shell files and removes helm-git commands; it adds or modifies no Ginkgo tests, assertions, waits, setup, or cleanup.
Microshift Test Compatibility	✅ Passed	The diff changes only one YAML image configuration and one shell script, removing helm-git; it adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff only removes helm-git setup from two YAML/shell files; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The HEAD^..HEAD diff only removes helm-git installation from a CI Dockerfile and Helm command script; it adds no manifests, replicas, affinity, topology spread, selectors, tolerations, or PDB const...
Ote Binary Stdout Contract	✅ Passed	The diff only removes helm-git commands from YAML and a shell step. It adds no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch only deletes helm-git installation lines from YAML and a shell script; it adds no Ginkgo e2e tests or IPv4/external-connectivity test behavior.
No-Weak-Crypto	✅ Passed	The commit only removes helm-git installation and listing commands; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	The verified commit only removes helm-git installation lines; changed files contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only removes helm-git installation and listing commands; it adds no logging or sensitive output. Existing credential and pod-log handling is unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-hyperfleet/hyperfleet-infra/OWNERS [ciaranRoche]
• ci-operator/step-registry/openshift-hyperfleet/OWNERS [ciaranRoche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@ciaranRoche: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-hyperfleet-hyperfleet-infra-main-integration	openshift-hyperfleet/hyperfleet-infra	presubmit	Ci-operator config changed
pull-ci-openshift-hyperfleet-hyperfleet-infra-main-validate	openshift-hyperfleet/hyperfleet-infra	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@ciaranRoche: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.