Fix: Use correct Windows Server 2022 template for vSphere provisioning

[rrasouli]

The clusterBot provisioning pipeline was using a stale template reference (windows-server-2022-template-qe-20241104) that no longer exists, causing all Windows node provisioning to fail. Update to use the correct ipv6-disabled template that is actively maintained in vSphere infrastructure.

Fixes consistent Windows node provisioning failures on vSphere clusters.

Summary by CodeRabbit

• Updates the OpenShift CI clusterBot provisioning pipeline to use the actively maintained IPv6-disabled Windows Server 2022 vSphere template.
• Prevents Windows node provisioning failures caused by the stale QE-specific template reference.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3b20dd7-381c-4cc8-a9b6-072dfd368882

📥 Commits

Reviewing files that changed from the base of the PR and between 53f5757 and 053f364.

📒 Files selected for processing (1)

• ci-operator/step-registry/ipi/conf/vsphere/windows-machineset/ipi-conf-vsphere-windows-machineset-ref.yaml

---

Walkthrough

The vSphere Windows machineset configuration now selects the IPv6-disabled Windows Server 2022 image template by default.

Changes

Windows vSphere machine template

Layer / File(s)	Summary
Update default Windows image template ci-operator/step-registry/ipi/conf/vsphere/windows-machineset/ipi-conf-vsphere-windows-machineset-ref.yaml	The WINDOWS_OS_ID value now uses windows-golden-images/windows-server-2022-template-ipv6-disabled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 053f3

This localized change updates the Windows Server 2022 provisioning template reference; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change to the Windows Server 2022 vSphere provisioning template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only a YAML image-reference value; it adds no Ginkgo test title or dynamic test-name content.
Test Structure And Quality	✅ Passed	The commit changes one YAML template reference only; no Ginkgo test code, It blocks, or test setup is introduced.
Microshift Test Compatibility	✅ Passed	The PR changes only a vSphere YAML image reference; it adds no Ginkgo tests or MicroShift-incompatible test usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only the vSphere Windows template YAML and adds no Ginkgo e2e tests or multi-node assumptions; the SNO check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes only the WINDOWS_OS_ID image reference in a step-registry YAML file; it adds no deployment, controller, or scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The PR changes one YAML template reference only; no Go or process-level code changes introduce stdout writes that could violate the OTE JSON stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes one YAML image-template reference only; it adds no Ginkgo e2e test and introduces no IPv4 or external-connectivity requirement.
No-Weak-Crypto	✅ Passed	The PR changes only a vSphere Windows template identifier. The new value and related commands contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR changes only the WINDOWS_OS_ID image reference; the YAML and sibling step files contain no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only the WINDOWS_OS_ID YAML default from one template reference to another; it adds no logging or sensitive data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrasouli
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ipi/conf/vsphere/windows-machineset/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@rrasouli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-priv-openshift-tests-private-release-4.22-debug-winc-vsphere-ipi-disconnected	openshift-priv/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-priv-openshift-tests-private-release-4.21-debug-winc-vsphere-ipi-disconnected	openshift-priv/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-priv-openshift-tests-private-release-4.20-debug-winc-vsphere-ipi-disconnected	openshift-priv/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.22-debug-winc-vsphere-ipi-disconnected	openshift/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.21-debug-winc-vsphere-ipi-disconnected	openshift/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.20-debug-winc-vsphere-ipi-disconnected	openshift/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-vsphere-ipi-disconnected	openshift/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.18-debug-winc-vsphere-ipi-disconnected	openshift/openshift-tests-private	presubmit	Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.16-debug-winc-vsphere-ipi	openshift/openshift-tests-private	presubmit	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-disconnected-ovn-winc-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-vsphere-ipi-ovn-winc-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-disconnected-ovn-winc-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-disconnected-ovn-winc-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-5.1-amd64-nightly-vsphere-ipi-ovn-winc-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-ipi-ovn-winc-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-ipi-ovn-winc-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-proxy-ovn-winc-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-ovn-winc-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-ovn-winc-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-ovn-winc-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-vsphere-ipi-disconnected-ovn-winc-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-vsphere-ipi-ovn-winc-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-ipi-disconnected-ovn-winc-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-ipi-ovn-winc-f14	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@rrasouli: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.