Skip to content

Increase CIO lint mem limit - #83462

Open
eth1030 wants to merge 1 commit into
openshift:mainfrom
eth1030:cio-lint-memory
Open

Increase CIO lint mem limit#83462
eth1030 wants to merge 1 commit into
openshift:mainfrom
eth1030:cio-lint-memory

Conversation

@eth1030

@eth1030 eth1030 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Following #79791
test lint fails multiple times with

/go/bin/golangci-lint
GOOS=linux GOARCH=amd64 CGO_ENABLED=1 GOFLAGS="-tags=fips_enabled" GOEXPERIMENT=boringcrypto GOLANGCI_LINT_CACHE=/tmp/golangci-cache golangci-lint run -c boilerplate/openshift/golang-osd-operator/golangci.yml --new-from-rev=1584c54c3b080303353f76f6f7beaf39ae3d5500 ./... 
INFO[2026-08-14T16:46:52Z] Ran for 1s                                   
ERRO[2026-08-14T16:46:52Z] Some steps failed:                           
ERRO[2026-08-14T16:46:52Z] 
  * could not run steps: step lint failed: test "lint" failed: could not watch pod: the pod ci-op-8nibfrg1/lint failed after 16m20s (failed containers: test): ContainerFailed one or more containers exited
Container test exited with code 137, reason OOMKilled

increasing memory limit to address this

Summary by CodeRabbit

The OpenShift CI configuration for the Cloud Ingress Operator increases the CIO lint container memory limit to 6Gi. It also adds CPU and memory requests of 100m and 200Mi. This prevents repeated lint test failures caused by out-of-memory termination with exit code 137.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2a13d354-a996-46ca-a8c7-4ebd3093b03e

📥 Commits

Reviewing files that changed from the base of the PR and between 6b528f0 and e876f45.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/cloud-ingress-operator/openshift-cloud-ingress-operator-master.yaml

Walkthrough

The CI configuration adds dedicated resource requests and a memory limit for the lint container.

Changes

Lint Resource Configuration

Layer / File(s) Summary
Configure lint container resources
ci-operator/config/openshift/cloud-ingress-operator/openshift-cloud-ingress-operator-master.yaml
The lint container now requests 100m CPU and 200Mi memory, with a 6Gi memory limit.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e876f

This localized CI configuration change increases memory for lint jobs; no actionable merge-blocking risk remains after the normal configuration and CI checks.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: increasing the memory limit for the CIO lint container.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff only adds lint container resource settings in a CI YAML file; it does not add or modify any Ginkgo test titles.
Test Structure And Quality ✅ Passed The commit only adds YAML resource settings for the lint job; it introduces no Ginkgo test code or It blocks subject to this check.
Microshift Test Compatibility ✅ Passed The diff only adds lint container resource settings in a YAML file; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only CI YAML resource settings and adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only adds CPU and memory settings for the CI lint test container; it adds no replicas, affinity, topology spread, node selectors, tolerations, or PDBs.
Ote Binary Stdout Contract ✅ Passed The diff changes only six YAML resource-setting lines for the lint container; it adds no process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff only adds CPU and memory settings for the lint container in a YAML config; it adds no Ginkgo e2e tests or network connectivity.
No-Weak-Crypto ✅ Passed The HEAD-parent diff adds only lint CPU and memory resource settings; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed The diff adds only lint CPU and memory resources. It introduces no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds lint container CPU and memory resource settings; it introduces no logging, credentials, identifiers, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eth1030
Once this PR has been reviewed and has the lgtm label, please assign sam-nguyen7 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eth1030: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-ingress-operator-master-coverage openshift/cloud-ingress-operator presubmit Ci-operator config changed
pull-ci-openshift-cloud-ingress-operator-master-e2e-binary-build-success openshift/cloud-ingress-operator presubmit Ci-operator config changed
pull-ci-openshift-cloud-ingress-operator-master-images openshift/cloud-ingress-operator presubmit Ci-operator config changed
pull-ci-openshift-cloud-ingress-operator-master-lint openshift/cloud-ingress-operator presubmit Ci-operator config changed
pull-ci-openshift-cloud-ingress-operator-master-test openshift/cloud-ingress-operator presubmit Ci-operator config changed
pull-ci-openshift-cloud-ingress-operator-master-validate openshift/cloud-ingress-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@geowa4

geowa4 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@geowa4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@geowa4

geowa4 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse max

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@geowa4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@eth1030: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cloud-ingress-operator/master/lint e876f45 link unknown /pj-rehearse pull-ci-openshift-cloud-ingress-operator-master-lint
ci/rehearse/openshift/cloud-ingress-operator/master/validate e876f45 link unknown /pj-rehearse pull-ci-openshift-cloud-ingress-operator-master-validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants