hypershift-hostedcluster-workflow: Fix NodePool wait to use dynamic spec.clusterName lookup - #83467
Conversation
HyperShift creates NodePools with AZ suffixes (e.g. cluster-us-east-1a)
rather than using the bare cluster name. The previous oc wait used
nodepool/${CLUSTER_NAME} which failed with NotFound.
Replace the hardcoded name with a jsonpath lookup on spec.clusterName to
discover all NodePools belonging to this cluster, then wait for each one
individually. Also fix the failure diagnostics to dump all matching
NodePools instead of the non-existent one.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
A total of 78 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
a7a4089
into
openshift:main
|
@redhat-chai-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Fix the NodePool readiness wait introduced in #83460 to correctly discover NodePools by
spec.clusterNameinstead of using the cluster name directly.Problem
HyperShift creates NodePools with availability zone suffixes (e.g.
${CLUSTER_NAME}-us-east-1a), but the wait usednodepool/${CLUSTER_NAME}— which doesn't match any actual resource:Fix
oc get nodepool -n clusterswith a jsonpath filter onspec.clusterNameto dynamically discover all NodePools belonging to the clusterFixes the regression introduced by #83460.
AI-generated. Review for accuracy.
@deepsm007 requested in Slack thread