remove duplicate sudo_set_subnet_owner_hotkey#2777
Conversation
JohnReedV
added
the
skip-cargo-audit
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: established opentensor-associated contributor with repo write permission and substantial prior merged PR history; branch remove-duplicate-set-sn-owner-key -> devnet-ready. Static-only review found a narrow runtime diff: the duplicate FindingsNo findings. Prior-comment reconciliation
ConclusionI found no malicious indicators or security vulnerabilities in the current diff. The prior runtime-versioning concern remains addressed on the current base/head state. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor: LIKELY by recent subtensor PR history; author has repo write access and substantial prior contribution history, so calibrated as an established contributor. Description discrepancy: the PR body still says this bumps Duplicate-work check found overlapping open PRs on broad runtime/pallet files, but none are direct duplicates of this removal. No auto-fix was applied. I attempted the configured devnet runtime-version query for spec-version validation, but DNS resolution failed in this environment; review was otherwise static only. Findings
Prior-comment reconciliation
ConclusionThe runtime-facing alias removal is consistent with the proxy filter and the remaining call path. Approving with low-severity cleanup comments for stale commented code and test documentation. 📜 Previous run (superseded)
|
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
| // Deprecated for sudo_set_sn_owner_hotkey | ||
| // #[pallet::call_index(64)] | ||
| // #[pallet::weight(Weight::from_parts(3_918_000, 0) // TODO: add benchmarks | ||
| // .saturating_add(T::DbWeight::get().writes(1_u64)))] | ||
| // pub fn sudo_set_subnet_owner_hotkey( | ||
| // origin: OriginFor<T>, | ||
| // netuid: NetUid, | ||
| // hotkey: <T as frame_system::Config>::AccountId, | ||
| // ) -> DispatchResult { | ||
| // pallet_subtensor::Pallet::<T>::do_set_sn_owner_hotkey(origin, netuid, &hotkey) | ||
| // } |
There was a problem hiding this comment.
Can we just remove the comment maybe?
There was a problem hiding this comment.
I left it so we don't re-use the call index.
3 participants
Description
Removes the duplicate
sudo_set_subnet_owner_hotkeyadmin-utils extrinsic. The remainingsudo_set_sn_owner_hotkeyextrinsic continues to dispatch to the same underlying subnet owner hotkey setter.Changes
sudo_set_subnet_owner_hotkeydispatch path frompallets/admin-utils/src/lib.rs.sudo_set_sn_owner_hotkeybenchmark and weight path in place.runtime/src/lib.rsspec_versionfrom421to422for the runtime metadata change.Behavioral Impact
The duplicate call name is no longer available in runtime metadata. Callers should use
sudo_set_sn_owner_hotkey; the underlying owner-hotkey update behavior is unchanged.Testing
Not specified in the original PR body. Auditor review was static only.