Restore C3 hard block: APIService not yet fully supported in OLMv1 - #22
Open
tmshort wants to merge 1 commit into
Open
Restore C3 hard block: APIService not yet fully supported in OLMv1#22tmshort wants to merge 1 commit into
tmshort wants to merge 1 commit into
Conversation
The operator-controller PR #2885 added the rendering infrastructure (BundleCSVAPIServiceGenerator, validator, cert provider support) for APIService objects, but the code is not yet registered in ResourceGenerators or BundleValidator pending end-to-end Boxcutter path validation. C3 is therefore reinstated as a hard block in the migration tool. Operators with owned APIService definitions remain ineligible until OLMv1 supports them end-to-end. SDD documents updated: requirements.md: C3 is a hard block (not temporary), updated rationale plan.md: Phase 7 reflects infrastructure status; C3 removal deferred Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
grokspawn
reviewed
Aug 27, 2026
| } | ||
|
|
||
| // checkNoAPIServices enforces C3 — no owned APIService definitions (hard block). | ||
| // OLMv1's registry+v1 renderer does not yet fully support APIService-based operators |
There was a problem hiding this comment.
Suggested change
| // OLMv1's registry+v1 renderer does not yet fully support APIService-based operators | |
| // OLMv1's registry+v1 renderer does not support APIService-based operators |
grokspawn
reviewed
Aug 27, 2026
| // checkNoAPIServices enforces C3 — no owned APIService definitions (hard block). | ||
| // OLMv1's registry+v1 renderer does not yet fully support APIService-based operators | ||
| // end-to-end. The underlying implementation exists in operator-controller as infrastructure | ||
| // but is not yet wired into the Boxcutter rendering path. |
There was a problem hiding this comment.
Suggested change
| // but is not yet wired into the Boxcutter rendering path. | |
| // but is not supported by the Boxcutter rendering path. |
grokspawn
reviewed
Aug 27, 2026
| return CheckResult{ | ||
| Name: "No APIService definitions", | ||
| Passed: false, | ||
| Message: "CSV has spec.apiservicedefinitions.owned set; OLMv1 does not yet fully support APIService-based operators", |
There was a problem hiding this comment.
Suggested change
| Message: "CSV has spec.apiservicedefinitions.owned set; OLMv1 does not yet fully support APIService-based operators", | |
| Message: "CSV has spec.apiservicedefinitions.owned set; OLMv1 does not support APIService-based operators", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the C3 hard block in the migration compatibility checker and updates
the SDD documents to accurately reflect the current state of APIService support
in OLMv1.
Background
OPRUN-4723 added the rendering
infrastructure for APIService objects to operator-controller
(PR #2885):
BundleCSVAPIServiceGenerator,CheckAPIServiceDeploymentReferentialIntegrity,and cert provider support. However, this infrastructure is not yet registered
in
ResourceGeneratorsorBundleValidator— it is retained as code for afuture release pending end-to-end Boxcutter path validation.
As a result, OLMv1 does not yet fully support APIService-based operators and the
migration tool's C3 hard block must be restored.
Changes
migration/pkg/migration/compatibility.gocheckNoAPIServicesfunction (C3 hard block)CheckCompatibilitywith an updated messageexplaining that OLMv1 infrastructure exists but is not yet wired end-to-end
specs/20260821-migration-v0-to-v1/requirements.mdthe actual state: rendering infrastructure exists but is not yet activated
specs/20260821-migration-v0-to-v1/plan.mdReviewer Checklist