AO3-6731 Fix order of Recent Bookmarks in User and Pseud dashboards - #5774
AO3-6731 Fix order of Recent Bookmarks in User and Pseud dashboards#5774luis-pabon-tf wants to merge 7 commits into
Conversation
| Then I should be on the dashboard page for user "meatloaf" with pseud "meatloaf" | ||
| And I should see "Recent bookmarks" | ||
| And I should not see "Work One" within "#user-bookmarks" | ||
| And I should see "Work Six" within "#user-bookmarks" |
There was a problem hiding this comment.
I tried being thorough on this test, but if this is overkill let me know and I can try trimming it.
|
I'm a fool and deleted this branch locally, it's still here for testing! |
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Just some nitpicks on the tests! Another option that would probably run a bit quicker than the feature test would be using RSpec to test that bookmarks is assigned correctly on the show action for users and pseuds.
I'm a little bit nervous that we could see some intermittent failures on this test during quick runs when multiple bookmarks might potentially be created with the same timestamp, but we can just watch for that and tweak things if it happens.
sarken
added
Priority: Medium
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
|
Thanks for the feedbacks! I think I got them all and this is ready for re-review. |
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Just one last tiny thing!
| And I should not see "Work One" within "#user-bookmarks" | ||
| And I should see "Work Six" within "#user-bookmarks" | ||
| When I go to the dashboard page for user "meatloaf" with pseud "meatloaf" | ||
| And I should see "Recent bookmarks" |
There was a problem hiding this comment.
This will need to be a Then, since we're testing the results of our When.
2 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6731
Purpose
Updates the sorting on the query that loads bookmarks on the User and Pseud controllers so that they sort by
created_at, which is the expected behavior.Credit
Luis Pabon (they/he)