AO3-7554 i18n - search results help for tags - #5972
Conversation
|
Hi can you fill in the form and there are some hound comments. ( Sorry didn't see the work in progress ) |
sherin
changed the title
sherin
changed the title
ASalbenblatt
left a comment
ASalbenblatt
left a comment
There was a problem hiding this comment.
Just a few fixes I saw, great work though!!
There was a problem hiding this comment.
I'm just putting this here because it comes up a lot in this file, but translators shouldn't be expected to know what kbd and samp mean. I might instead use something more descriptive like as_entered and result respectively (or whatever you want if you can come up with something clearer or better)
| refine: If there are too many tags, try refining your search, rather than paging through the results. | ||
| sorting: Very new tags will be at the top of the list. Otherwise the list is sorted alphabetically by type and then name. | ||
| tags_search_text: | ||
| and: |
There was a problem hiding this comment.
I think this would be better named space:
| double_quote: | ||
| description_html: "%{harry_lockhart_kbd} will find %{harry_lockhart_samp} but not %{harry_potter_gilderoy_lockhart_samp}." | ||
| harry_lockhart_kbd: '"Harry Lockhart"' | ||
| harry_lockhart_samp: '"Harry Lockhart"' |
There was a problem hiding this comment.
Assuming you agree, I think the quotes on the samp were actually a typo in the original, because there would probably only be a tag Harry Lockhart not "Harry Lockhart", so I you can remove them unless you think they might not be one.
3 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7554
Purpose
Move the two tag search help related files to be i18n compatible. As part of that, I've:
Testing Instructions
In the jira ticket.
Credit
Sherin (she)