AO3-7548 i18n tagset-about, tagset-tag-associations and tagset-batch-load help files - #5981
AO3-7548 i18n tagset-about, tagset-tag-associations and tagset-batch-load help files#5981sherin wants to merge 11 commits into
Conversation
sherin
changed the title
sarken
changed the title
| acronym: non-con | ||
| title: non-consensual sex | ||
| tag_sets_about: | ||
| delete_tag_set_warning_strong: can delete the tag set or change it without warning |
There was a problem hiding this comment.
The _strong suffix might be confusing to a translator who doesn't know HTML. The way you're supposed to do this is to make the key here just delete_tag_set_warning and then have the variable be something descriptive so they see %{delete_tag_set_warning_bold} in the other string.
There was a problem hiding this comment.
good point, thank you
|
|
||
| <% end %> | ||
| </div> No newline at end of file |
There was a problem hiding this comment.
Since you're already modifying this file pretty heavily could you please add the missing newline at the end here
|
|
||
| <fieldset class="tagset"> | ||
| <legend>Tags In Set <% unless @tag_set.new_record? || !@tag_set.tag_set || @tag_set.tag_set.tags.empty? %><%= ts('(check to remove)') %><% end %></legend> | ||
| <legend>Tags In Set <% unless @tag_set.new_record? || !@tag_set.tag_set || @tag_set.tag_set.tags.empty? %><%= t(".check_to_remove") %><% end %></legend> |
There was a problem hiding this comment.
Our i18n standards say that even if a text fragment is identical in two places it should be put in two different locales like .check_to_remove_tags and .check_to_remove_associations in case they end up being different in another language (like maybe tags and associations have different genders and that requires remove to be conjugated differently or something)
There was a problem hiding this comment.
that makes sense, thank you!
| <dt class="landmark"><%= t(".submit") %></dt> | ||
| <dd class="submit actions"><%= form.submit t(".submit") %></dd> |
There was a problem hiding this comment.
These I think are fine to be duplicated because they are both referring to the same button
| <li><%= link_to t(".new_tag_set_link"), new_tag_set_path %></li> | ||
| <li><%= link_to t(".tags_link"), tags_path %></li> |
There was a problem hiding this comment.
These are probably better described as _button instead of _link
ASalbenblatt
left a comment
ASalbenblatt
left a comment
There was a problem hiding this comment.
Looks great, thanks!
2 participants
…_tag_sets/index
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7548
Purpose
Move 3 help files over to erb with i18n compliance. In addition, for owned_tag_sets/index.html, I've also fixed and moved its translation strings to the en locale file (converting
tscalls tot).Testing Instructions
Refer ticket
Credit
sherin